From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22589 invoked by alias); 31 Aug 2010 20:34:25 -0000 Received: (qmail 22580 invoked by uid 22791); 31 Aug 2010 20:34:24 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 20:34:20 +0000 Received: (qmail 18354 invoked from network); 31 Aug 2010 20:34:19 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 31 Aug 2010 20:34:19 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [commit] Build memmem with -Wno-error. Date: Tue, 31 Aug 2010 20:34:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Jan Kratochvil , Joel Brobecker References: <1283281706-30409-1-git-send-email-brobecker@adacore.com> <201008312048.35034.pedro@codesourcery.com> <20100831201455.GA24500@host1.dyn.jankratochvil.net> In-Reply-To: <20100831201455.GA24500@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201008312134.16818.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00577.txt.bz2 On Tuesday 31 August 2010 21:14:55, Jan Kratochvil wrote: > On Tue, 31 Aug 2010 21:48:34 +0200, Pedro Alves wrote: > > It would be better to come up with > > an $(INTERNAL_CFLAGS) variant that does not include -Werror in the first > > place, and use that instead in the memmem.o rule. gdb/Makefile.in uses > > INTERNAL_WARN_CFLAGS for exactly that. I suggest to do the same here. Take > > a look at the monitor.o rule in gdb/Makefile.in. > > This is a longterm cosmetic problem. Anytime I modify anything in defs.h VIM > jumps to the warnings in monitor.c which I have to skip. > > There should be the explicit -Wno-format-nonliteral form. Just removing > -Wformat-nonliteral or -Werror is not enough. > > Combined the patch together with making it more restrictive. It should no > longer be IMO such a concern since Joel started removing -Werror for releases. > > Tested compilation on x86_64-fedora14snapshot-linux-gnu. I'm not sure whether this may break the build on older gcc's, but given --disable-werror, it's fine with me to give this a try. -- Pedro Alves