From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [commit] Build memmem with -Wno-error.
Date: Tue, 31 Aug 2010 22:07:00 -0000 [thread overview]
Message-ID: <20100831220720.GQ2986@adacore.com> (raw)
In-Reply-To: <201008312259.20672.pedro@codesourcery.com>
> Thanks. I was more concerned with the the fact that the file after
> the patch is build with -Werror, and that that particular -W flag may
> not exist in such order versions, and/or another flag is necessary to
> disable the warning in question. One would assume not though, hence
> me being fine with this until proven otherwise. :-)
As far as I could tell, there is some configury to avoid the use
of that flag if the compiler does not support it.
build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith [...]"
for w in ${build_warnings}; do
case $w in
-Werr*) WERROR_CFLAGS=-Werror ;;
*) # Check that GCC accepts it
saved_CFLAGS="$CFLAGS"
CFLAGS="$CFLAGS $w"
AC_TRY_COMPILE([],[],WARN_CFLAGS="${WARN_CFLAGS} $w",)
CFLAGS="$saved_CFLAGS"
esac
done
?
--
Joel
next prev parent reply other threads:[~2010-08-31 22:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 19:08 Joel Brobecker
2010-08-31 19:48 ` Pedro Alves
2010-08-31 20:15 ` Jan Kratochvil
2010-08-31 20:34 ` Pedro Alves
2010-08-31 21:22 ` Joel Brobecker
2010-08-31 21:59 ` Pedro Alves
2010-08-31 22:07 ` Joel Brobecker [this message]
2010-08-31 22:13 ` Jan Kratochvil
2010-08-31 22:21 ` Pedro Alves
2010-09-02 14:54 ` Jan Kratochvil
2010-08-31 22:04 ` Joel Brobecker
2010-08-31 22:23 ` Pedro Alves
2010-09-01 1:56 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831220720.GQ2986@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).