From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13064 invoked by alias); 31 Aug 2010 22:21:14 -0000 Received: (qmail 13052 invoked by uid 22791); 31 Aug 2010 22:21:13 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 22:21:08 +0000 Received: (qmail 19925 invoked from network); 31 Aug 2010 22:21:06 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 31 Aug 2010 22:21:06 -0000 From: Pedro Alves To: Jan Kratochvil Subject: Re: [commit] Build memmem with -Wno-error. Date: Tue, 31 Aug 2010 22:21:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Joel Brobecker , gdb-patches@sourceware.org References: <1283281706-30409-1-git-send-email-brobecker@adacore.com> <20100831220720.GQ2986@adacore.com> <20100831221314.GA12272@host1.dyn.jankratochvil.net> In-Reply-To: <20100831221314.GA12272@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201008312321.04707.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00584.txt.bz2 On Tuesday 31 August 2010 23:13:14, Jan Kratochvil wrote: > On Wed, 01 Sep 2010 00:07:20 +0200, Joel Brobecker wrote: > > As far as I could tell, there is some configury to avoid the use > > of that flag if the compiler does not support it. > > Just there could be a GCC historical moment when the message > warning: format not a string literal, argument types not checked > > was already produced while neither -Wformat-nonliteral nor > -Wno-format-nonliteral was yet supported. > > The change enabling -Werror in such case would break it. But let's pretend > -Wformat-nonliteral + -Wno-format-nonliteral were introduced at the moment > warning: format not a string literal, argument types not checked > > was introduced. Exactly. > (I will check it in later.) -- Pedro Alves