From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] include alloca.h if available.
Date: Wed, 01 Sep 2010 01:59:00 -0000 [thread overview]
Message-ID: <20100901015944.GT2986@adacore.com> (raw)
In-Reply-To: <201008312055.40504.pedro@codesourcery.com>
> > On LynxOS, alloca is defined in allocal.h. This fixes one warning that
> > occurs when building GDBserver for LynxOS.
>
> No objections here. One note.
Cool - checked in.
> Every include of malloc.h in gdbserver's common code:
>
> $ grep malloc\\.h *.c
> gdbreplay.c:#include <malloc.h>
> mem-break.c:#include <malloc.h>
> server.c:#include <malloc.h>
> tracepoint.c:#include <malloc.h>
> utils.c:#include <malloc.h>
> win32-low.c:#include <malloc.h>
>
> is there for alloca on mingw32. It might have made
> sense to keep those together. I don't really care that
> much either way, just pointing it out. :-)
If it is just for malloc, it sounds like the include is no longer
necessary? Unless of course malloc.h is the only location where
alloca is defined on mingw32. Either way, since I'm working in
that area of the code, might as well look at it - I think I'm
setup to build the gdbserver on MinGW.
--
Joel
next prev parent reply other threads:[~2010-09-01 1:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 19:06 Joel Brobecker
2010-08-31 19:55 ` Pedro Alves
2010-09-01 1:59 ` Joel Brobecker [this message]
2010-09-01 4:38 ` Joel Brobecker
2010-09-01 11:41 ` Pedro Alves
2010-09-01 17:10 ` [RFA/gdbserver] Move malloc.h include to server.h Joel Brobecker
2010-09-01 17:12 ` Pedro Alves
2010-09-01 17:30 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901015944.GT2986@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).