From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17494 invoked by alias); 1 Sep 2010 01:59:59 -0000 Received: (qmail 17404 invoked by uid 22791); 1 Sep 2010 01:59:58 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 01:59:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3124E2BABBB; Tue, 31 Aug 2010 21:59:52 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1-0qavym2z2V; Tue, 31 Aug 2010 21:59:52 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id ED7582BAB9D; Tue, 31 Aug 2010 21:59:51 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 101A7F599F; Wed, 1 Sep 2010 03:59:44 +0200 (CEST) Date: Wed, 01 Sep 2010 01:59:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] include alloca.h if available. Message-ID: <20100901015944.GT2986@adacore.com> References: <1283281511-30193-1-git-send-email-brobecker@adacore.com> <201008312055.40504.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201008312055.40504.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00002.txt.bz2 > > On LynxOS, alloca is defined in allocal.h. This fixes one warning that > > occurs when building GDBserver for LynxOS. > > No objections here. One note. Cool - checked in. > Every include of malloc.h in gdbserver's common code: > > $ grep malloc\\.h *.c > gdbreplay.c:#include > mem-break.c:#include > server.c:#include > tracepoint.c:#include > utils.c:#include > win32-low.c:#include > > is there for alloca on mingw32. It might have made > sense to keep those together. I don't really care that > much either way, just pointing it out. :-) If it is just for malloc, it sounds like the include is no longer necessary? Unless of course malloc.h is the only location where alloca is defined on mingw32. Either way, since I'm working in that area of the code, might as well look at it - I think I'm setup to build the gdbserver on MinGW. -- Joel