From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18005 invoked by alias); 1 Sep 2010 16:20:11 -0000 Received: (qmail 17995 invoked by uid 22791); 1 Sep 2010 16:20:09 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 16:20:04 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 74F842BAC56; Wed, 1 Sep 2010 12:20:02 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QB-21C+yfOZc; Wed, 1 Sep 2010 12:20:02 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 424012BAC5F; Wed, 1 Sep 2010 12:20:02 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 12999F599F; Wed, 1 Sep 2010 18:19:53 +0200 (CEST) Date: Wed, 01 Sep 2010 16:20:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: sami wagiaalla , gdb-patches@sourceware.org Subject: Re: Regression for gdb.stabs/gdb11479.exp [Re: [patch 1/2] Use custom hash function with bcache] Message-ID: <20100901161952.GX2986@adacore.com> References: <4C6946E1.6000709@redhat.com> <4C6D5C83.3050602@redhat.com> <4C756132.5050301@redhat.com> <20100901082539.GA24609@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100901082539.GA24609@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00016.txt.bz2 > > 2010-08-25 Sami Wagiaalla > > > > * psymtab.c (add_psymbol_to_bcache): Remove 'static' from > > 'static partial_symbol psymbol'. > > (psymbol_hash): New function. > > (psymbol_compare): New function. > > * bcache.c (hash_continue): New. > > (hash): Use hash_continue. > > * bcache.c: Add hash_function and compare_function > > pointers to bcache struct. > > (bcache_full): Use bcache->hash_function, and > > bcache->compare_function. > > (bcache_compare): New function. > > (bcache_xmalloc): Take hash_function and > > compare_function arguments and initialize the > > bcach's pointers. > > Updated comment. > > * objfiles.c (allocate_objfile): Updated. > > * symfile.c (reread_symbols): Updated. > > fb846e72510040325bffd8f755180ea0025108dc > http://sourceware.org/ml/gdb-cvs/2010-08/msg00197.html > > It has a regression for gdb.stabs/gdb11479.exp on all the tested distros > {x86_64,x86_64-m32,i686}-fedora{12,13,14snapshot}-linux-gnu even without > -lmcheck. Just so we don't duplicate efforts, I've have been looking into this. I'm not completely done, yet, but I've found something suspicious. For me, it causes a crash in gdb.ada/complete.exp: (gdb) b 7 Breakpoint 1 at 0x401f96: file /[...]/foo.adb, line 7. (gdb) run Starting program: /[...]/foo Breakpoint 1, foo () at /[...]/foo.adb:7 7 My_Global_Variable := Some_Local_Variable + 1; -- START (gdb) complete p my_glob [1] 22302 segmentation fault ../../../gdb foo -- Joel