* [patch] Adding 'reverse' to -list-target-features
@ 2010-09-01 16:14 Marc Khouzam
2010-09-01 16:39 ` Eli Zaretskii
2010-09-01 16:44 ` Pedro Alves
0 siblings, 2 replies; 6+ messages in thread
From: Marc Khouzam @ 2010-09-01 16:14 UTC (permalink / raw)
To: 'gdb-patches@sourceware.org', 'Pedro Alves',
'Michael Snyder'
Hi,
as was discussed in http://sourceware.org/ml/gdb/2010-08/msg00187.html
here is patch to add 'reverse' to the output of -list-target-features
There are small MI changes and small doc changes.
No regressions.
Thanks
Marc
2010-09-01 Marc Khouzam <marc.khouzam@ericsson.com>
* mi/mi-main.c (mi_cmd_list_target_features): Add `reverse'
as a feature reported by -list-target-features.
2010-09-01 Marc Khouzam <marc.khouzam@ericsson.com>
* gdb.texinfo (GDB/MI Miscellaneous Commands): Document new
feature `reverse' output by -list-target-features.
Index: gdb/doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.761
diff -u -r1.761 gdb.texinfo
--- gdb/doc/gdb.texinfo 31 Aug 2010 14:45:41 -0000 1.761
+++ gdb/doc/gdb.texinfo 1 Sep 2010 16:08:38 -0000
@@ -29030,6 +29030,9 @@
execution, which means that @value{GDBN} will accept further commands
while the target is running.
+@item reverse
+Indicates that the target is capable of reverse execution.
+
@end table
@subheading The @code{-list-thread-groups} Command
Index: gdb/mi/mi-main.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-main.c,v
retrieving revision 1.180
diff -u -r1.180 mi-main.c
--- gdb/mi/mi-main.c 13 Aug 2010 13:22:44 -0000 1.180
+++ gdb/mi/mi-main.c 1 Sep 2010 16:08:38 -0000
@@ -1700,6 +1700,8 @@
cleanup = make_cleanup_ui_out_list_begin_end (uiout, "features");
if (target_can_async_p ())
ui_out_field_string (uiout, NULL, "async");
+ if (target_can_execute_reverse)
+ ui_out_field_string (uiout, NULL, "reverse");
do_cleanups (cleanup);
return;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Adding 'reverse' to -list-target-features
2010-09-01 16:14 [patch] Adding 'reverse' to -list-target-features Marc Khouzam
@ 2010-09-01 16:39 ` Eli Zaretskii
2010-09-01 16:44 ` Marc Khouzam
2010-09-01 16:44 ` Pedro Alves
1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2010-09-01 16:39 UTC (permalink / raw)
To: Marc Khouzam; +Cc: gdb-patches, pedro, msnyder
> From: Marc Khouzam <marc.khouzam@ericsson.com>
> Date: Wed, 1 Sep 2010 12:13:32 -0400
>
> +@item reverse
> +Indicates that the target is capable of reverse execution.
This is okay, but please add a cross-reference to where reverse
execution is described.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [patch] Adding 'reverse' to -list-target-features
2010-09-01 16:39 ` Eli Zaretskii
@ 2010-09-01 16:44 ` Marc Khouzam
2010-09-01 17:02 ` Eli Zaretskii
2010-09-01 19:19 ` Marc Khouzam
0 siblings, 2 replies; 6+ messages in thread
From: Marc Khouzam @ 2010-09-01 16:44 UTC (permalink / raw)
To: 'Eli Zaretskii'
Cc: 'gdb-patches@sourceware.org',
'pedro@codesourcery.com', 'msnyder@vmware.com'
> -----Original Message-----
> From: Eli Zaretskii [mailto:eliz@gnu.org]
> Sent: Wednesday, September 01, 2010 12:41 PM
> To: Marc Khouzam
> Cc: gdb-patches@sourceware.org; pedro@codesourcery.com;
> msnyder@vmware.com
> Subject: Re: [patch] Adding 'reverse' to -list-target-features
>
> > From: Marc Khouzam <marc.khouzam@ericsson.com>
> > Date: Wed, 1 Sep 2010 12:13:32 -0400
> >
> > +@item reverse
> > +Indicates that the target is capable of reverse execution.
>
> This is okay, but please add a cross-reference to where reverse
> execution is described.
Updated the docs:
2010-09-01 Marc Khouzam <marc.khouzam@ericsson.com>
* mi/mi-main.c (mi_cmd_list_target_features): Add `reverse'
as a feature reported by -list-target-features.
2010-09-01 Marc Khouzam <marc.khouzam@ericsson.com>
* gdb.texinfo (GDB/MI Miscellaneous Commands): Document new
feature `reverse' output by -list-target-features.
Index: gdb/doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.761
diff -u -r1.761 gdb.texinfo
--- gdb/doc/gdb.texinfo 31 Aug 2010 14:45:41 -0000 1.761
+++ gdb/doc/gdb.texinfo 1 Sep 2010 16:42:07 -0000
@@ -29030,6 +29030,10 @@
execution, which means that @value{GDBN} will accept further commands
while the target is running.
+@item reverse
+Indicates that the target is capable of reverse execution.
+@xref{Reverse Execution}, for more information.
+
@end table
@subheading The @code{-list-thread-groups} Command
Index: gdb/mi/mi-main.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-main.c,v
retrieving revision 1.180
diff -u -r1.180 mi-main.c
--- gdb/mi/mi-main.c 13 Aug 2010 13:22:44 -0000 1.180
+++ gdb/mi/mi-main.c 1 Sep 2010 16:42:07 -0000
@@ -1700,6 +1700,8 @@
cleanup = make_cleanup_ui_out_list_begin_end (uiout, "features");
if (target_can_async_p ())
ui_out_field_string (uiout, NULL, "async");
+ if (target_can_execute_reverse)
+ ui_out_field_string (uiout, NULL, "reverse");
do_cleanups (cleanup);
return;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Adding 'reverse' to -list-target-features
2010-09-01 16:14 [patch] Adding 'reverse' to -list-target-features Marc Khouzam
2010-09-01 16:39 ` Eli Zaretskii
@ 2010-09-01 16:44 ` Pedro Alves
1 sibling, 0 replies; 6+ messages in thread
From: Pedro Alves @ 2010-09-01 16:44 UTC (permalink / raw)
To: gdb-patches; +Cc: Marc Khouzam, 'Michael Snyder'
On Wednesday 01 September 2010 17:13:32, Marc Khouzam wrote:
> Hi,
>
> as was discussed in http://sourceware.org/ml/gdb/2010-08/msg00187.html
> here is patch to add 'reverse' to the output of -list-target-features
> There are small MI changes and small doc changes.
Thank you!
> * mi/mi-main.c (mi_cmd_list_target_features): Add `reverse'
> as a feature reported by -list-target-features.
This part is okay. Please put this in the 7.2 branch as well.
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Adding 'reverse' to -list-target-features
2010-09-01 16:44 ` Marc Khouzam
@ 2010-09-01 17:02 ` Eli Zaretskii
2010-09-01 19:19 ` Marc Khouzam
1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2010-09-01 17:02 UTC (permalink / raw)
To: Marc Khouzam; +Cc: gdb-patches, pedro, msnyder
> From: Marc Khouzam <marc.khouzam@ericsson.com>
> CC: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>,
> "'pedro@codesourcery.com'" <pedro@codesourcery.com>,
> "'msnyder@vmware.com'"
> <msnyder@vmware.com>
> Date: Wed, 1 Sep 2010 12:44:05 -0400
>
> > > +@item reverse
> > > +Indicates that the target is capable of reverse execution.
> >
> > This is okay, but please add a cross-reference to where reverse
> > execution is described.
>
>
> Updated the docs:
This version is fine, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [patch] Adding 'reverse' to -list-target-features
2010-09-01 16:44 ` Marc Khouzam
2010-09-01 17:02 ` Eli Zaretskii
@ 2010-09-01 19:19 ` Marc Khouzam
1 sibling, 0 replies; 6+ messages in thread
From: Marc Khouzam @ 2010-09-01 19:19 UTC (permalink / raw)
To: 'gdb-patches@sourceware.org'
Cc: 'pedro@codesourcery.com', 'Eli Zaretskii',
'msnyder@vmware.com'
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Marc Khouzam
> Sent: Wednesday, September 01, 2010 12:44 PM
> To: 'Eli Zaretskii'
> Cc: 'gdb-patches@sourceware.org'; 'pedro@codesourcery.com';
> 'msnyder@vmware.com'
> Subject: RE: [patch] Adding 'reverse' to -list-target-features
>
>
>
> > -----Original Message-----
> > From: Eli Zaretskii [mailto:eliz@gnu.org]
> > Sent: Wednesday, September 01, 2010 12:41 PM
> > To: Marc Khouzam
> > Cc: gdb-patches@sourceware.org; pedro@codesourcery.com;
> > msnyder@vmware.com
> > Subject: Re: [patch] Adding 'reverse' to -list-target-features
> >
> > > From: Marc Khouzam <marc.khouzam@ericsson.com>
> > > Date: Wed, 1 Sep 2010 12:13:32 -0400
> > >
> > > +@item reverse
> > > +Indicates that the target is capable of reverse execution.
> >
> > This is okay, but please add a cross-reference to where reverse
> > execution is described.
>
>
> Updated the docs:
>
> 2010-09-01 Marc Khouzam <marc.khouzam@ericsson.com>
>
> * mi/mi-main.c (mi_cmd_list_target_features): Add `reverse'
> as a feature reported by -list-target-features.
>
> 2010-09-01 Marc Khouzam <marc.khouzam@ericsson.com>
> * gdb.texinfo (GDB/MI Miscellaneous Commands): Document new
> feature `reverse' output by -list-target-features.
>
> Index: gdb/doc/gdb.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
> retrieving revision 1.761
> diff -u -r1.761 gdb.texinfo
> --- gdb/doc/gdb.texinfo 31 Aug 2010 14:45:41 -0000 1.761
> +++ gdb/doc/gdb.texinfo 1 Sep 2010 16:42:07 -0000
> @@ -29030,6 +29030,10 @@
> execution, which means that @value{GDBN} will accept further commands
> while the target is running.
>
> +@item reverse
> +Indicates that the target is capable of reverse execution.
> +@xref{Reverse Execution}, for more information.
> +
> @end table
>
> @subheading The @code{-list-thread-groups} Command
> Index: gdb/mi/mi-main.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mi/mi-main.c,v
> retrieving revision 1.180
> diff -u -r1.180 mi-main.c
> --- gdb/mi/mi-main.c 13 Aug 2010 13:22:44 -0000 1.180
> +++ gdb/mi/mi-main.c 1 Sep 2010 16:42:07 -0000
> @@ -1700,6 +1700,8 @@
> cleanup = make_cleanup_ui_out_list_begin_end (uiout,
> "features");
> if (target_can_async_p ())
> ui_out_field_string (uiout, NULL, "async");
> + if (target_can_execute_reverse)
> + ui_out_field_string (uiout, NULL, "reverse");
>
> do_cleanups (cleanup);
> return;
Committed to HEAD and 7.2
Thanks
Marc
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-01 19:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-01 16:14 [patch] Adding 'reverse' to -list-target-features Marc Khouzam
2010-09-01 16:39 ` Eli Zaretskii
2010-09-01 16:44 ` Marc Khouzam
2010-09-01 17:02 ` Eli Zaretskii
2010-09-01 19:19 ` Marc Khouzam
2010-09-01 16:44 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).