From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16463 invoked by alias); 1 Sep 2010 18:18:46 -0000 Received: (qmail 16455 invoked by uid 22791); 1 Sep 2010 18:18:45 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 18:18:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4CD042BAB11; Wed, 1 Sep 2010 14:18:40 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kLf4hQgqqpgq; Wed, 1 Sep 2010 14:18:40 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 975F52BAB0B; Wed, 1 Sep 2010 14:18:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id BB8C7F599F; Wed, 1 Sep 2010 20:18:30 +0200 (CEST) Date: Wed, 01 Sep 2010 18:18:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Eli Zaretskii , Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t Message-ID: <20100901181830.GB2986@adacore.com> References: <20100830140814.GE2986@adacore.com> <20100831182829.GA16136@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100831182829.GA16136@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00031.txt.bz2 > I would prefer gdb_target_signal_t or also gdb_target_signal. > > Is one of those approved? I've just realize that this specific patch really only renames the type, in addition to adding a typedef. I'm just wondering why this is actually useful to you. I would have thought that we could avoid this patch entirely, and then let the next patch which introduces the gdb_target_signal as a struct just update all uses of the enum type. Once the struct has been introduced, we could do a rename if we feel that a better name of the enum can be found - I think that doing the rename would produce a patch that is smaller if done after introducing the struct wrapper first. Just some thoughts... -- Joel