From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3243 invoked by alias); 1 Sep 2010 18:45:16 -0000 Received: (qmail 3233 invoked by uid 22791); 1 Sep 2010 18:45:15 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 18:45:07 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o81IiivZ021568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 1 Sep 2010 14:44:45 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o81Iigbg009602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Sep 2010 14:44:44 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o81IigoW024867; Wed, 1 Sep 2010 20:44:42 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o81IifkQ024866; Wed, 1 Sep 2010 20:44:41 +0200 Date: Wed, 01 Sep 2010 18:45:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Joel Brobecker , Eli Zaretskii , Mark Kettenis Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t Message-ID: <20100901184441.GB24300@host1.dyn.jankratochvil.net> References: <20100901181830.GB2986@adacore.com> <20100901182943.GA23673@host1.dyn.jankratochvil.net> <201009011938.02189.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201009011938.02189.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00044.txt.bz2 On Wed, 01 Sep 2010 20:38:01 +0200, Pedro Alves wrote: > Weren't you proposing to end up with something like > "typedef struct target_signal target_signal"? > > Then you'd do "s/enum target_signal/target_signal/g" , which is > shorter. I have never proposed "target_signal" to be a type as I find it a possible parameter/variable name; although it is not in use now: grep -rP '(? But, if you guys want to rename the type, I won't stand in the way, > thought I'd suggest simply gdb_signal. One of "gdb or "target" in > "gdb_target" appears redundant to me. Removing the misleading "target" word would be great, "gdb_target" even suggests it is an in-GDB signal type, not a target-encoded signal type. Thanks, Jan