From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4935 invoked by alias); 1 Sep 2010 18:50:52 -0000 Received: (qmail 4927 invoked by uid 22791); 1 Sep 2010 18:50:51 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 18:50:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CB8932BAC3F; Wed, 1 Sep 2010 14:50:45 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EO4CQVDzLeRL; Wed, 1 Sep 2010 14:50:45 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7AE0E2BABB3; Wed, 1 Sep 2010 14:50:45 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D6049F599F; Wed, 1 Sep 2010 20:50:35 +0200 (CEST) Date: Wed, 01 Sep 2010 18:50:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/9]#2 Change target_signal_t to a struct Message-ID: <20100901185035.GF2986@adacore.com> References: <20100830071150.GD6831@host1.dyn.jankratochvil.net> <20100901182558.GA2422@adacore.com> <20100901183941.GA24300@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100901183941.GA24300@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00045.txt.bz2 > I do not understand now. The struct must be defined, not just declared. > GDB sources use variables of its type, not just pointers to it. Ah, yes, that's right. > Or do you just mean to move > TARGET_SIGNAL_NUMBER [...] > from common/gdb_signals.h to common/signals.c and remove > TARGET_SIGNAL_INITIALIZER Given the above, I don't think this is going to be necessary. -- Joel