From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30971 invoked by alias); 1 Sep 2010 19:08:03 -0000 Received: (qmail 30963 invoked by uid 22791); 1 Sep 2010 19:08:03 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 19:07:59 +0000 Received: (qmail 15471 invoked from network); 1 Sep 2010 19:07:57 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Sep 2010 19:07:57 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t Date: Wed, 01 Sep 2010 19:08:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Jan Kratochvil , Joel Brobecker , Eli Zaretskii , Mark Kettenis References: <20100901183952.GE2986@adacore.com> <20100901185112.GC24300@host1.dyn.jankratochvil.net> In-Reply-To: <20100901185112.GC24300@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201009012007.55983.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00050.txt.bz2 I think that if we do rename target_signal/gdb_signal, it becomes easier for review to catch these bad conversions, and easier to not write then in the first place. I wonder if switching on "-Wc++-compat" wouldn't catch these (at least with recent enough gccs) and be more productive than switching to a struct. /me ducks. -- Pedro Alves