From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org,
Joel Brobecker <brobecker@adacore.com>,
Eli Zaretskii <eliz@gnu.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
Date: Wed, 01 Sep 2010 20:23:00 -0000 [thread overview]
Message-ID: <20100901201025.GA30493@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <201009012059.36696.pedro@codesourcery.com>
On Wed, 01 Sep 2010 21:59:36 +0200, Pedro Alves wrote:
> Anyway, personally, I'd just do a enum target_signal/enum gdb_signal
> rename, and stay with that.
I do not mind about this point, someone can post it.
> But, here's another idea of how to get compiler warnings/errors,
> that I think is more transparent to code throughout:
>
> /* An empty struct. It's the instances we care about. */
> struct gdb_signal_1
> {
> };
OK, just that's a new patch. I coded this conversion to a struct just for the
purpose of the patch #7. I would have never started to code that just for the
purpose of a code cleanup.
Now I thought it is reusable at least as a code cleanup when it is already in
IMO an acceptable state.
I also found as an advantage target_signal_t as a struct could get extended by
additional information later, as has been done now (although unnecessarily
- not completely wrongly) for siginfo, addressing the "gdb/signals.h" part:
However, it is
recognized that this set of signals has limitations (such as not
distinguishing between various kinds of SIGSEGV, or not
distinguishing hitting a breakpoint from finishing a single step).
So in the future we may get around this either by adding additional
signals for breakpoint, single-step, etc., or by adding signal
codes; the latter seems more in the spirit of what BSD, System V,
etc. are doing to address these issues. */
Therefore going to drop this part. I will repost those few fixes that have
been found by this patchset. I will re-post the patch #7 as a linux-nat.c
only one (as GDB is not yet ready for a regression-free gdbserver-only
switch).
Thanks,
Jan
next prev parent reply other threads:[~2010-09-01 20:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 7:11 Jan Kratochvil
2010-08-30 8:14 ` Mark Kettenis
2010-08-30 8:24 ` Jan Kratochvil
2010-08-30 10:09 ` Eli Zaretskii
2010-08-30 11:11 ` Mark Kettenis
2010-08-30 14:08 ` Joel Brobecker
2010-08-31 18:28 ` Jan Kratochvil
2010-08-31 18:45 ` Mark Kettenis
2010-09-01 2:03 ` Joel Brobecker
2010-09-01 18:18 ` Joel Brobecker
2010-09-01 18:30 ` Jan Kratochvil
2010-09-01 18:38 ` Pedro Alves
2010-09-01 18:45 ` Jan Kratochvil
2010-09-01 18:40 ` Joel Brobecker
2010-09-01 18:51 ` Jan Kratochvil
2010-09-01 19:08 ` Pedro Alves
2010-09-01 19:28 ` Jan Kratochvil
2010-09-01 20:06 ` Pedro Alves
2010-09-01 20:06 ` Daniel Jacobowitz
2010-09-01 20:10 ` Pedro Alves
2010-09-02 9:46 ` Pedro Alves
2010-09-02 14:01 ` Jan Kratochvil
2010-09-02 15:36 ` Joel Brobecker
2010-09-02 19:02 ` Pedro Alves
2010-09-02 20:46 ` Jan Kratochvil
2010-09-07 18:59 ` Jan Kratochvil
2010-09-02 16:02 ` Joel Brobecker
2010-09-02 17:04 ` Jan Kratochvil
2010-09-06 0:29 ` Jan Kratochvil
2010-09-06 13:30 ` Pedro Alves
2010-09-06 14:52 ` Jan Kratochvil
2010-09-08 23:42 ` Jan Kratochvil
2010-09-01 20:23 ` Jan Kratochvil [this message]
2010-09-01 20:30 ` Mark Kettenis
2010-09-01 20:47 ` Pedro Alves
2010-09-01 21:32 ` Joseph S. Myers
2010-09-01 19:12 ` Joel Brobecker
2010-09-01 22:37 ` Tom Tromey
2010-08-30 14:11 ` Eli Zaretskii
2010-08-30 17:34 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901201025.GA30493@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).