From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26231 invoked by alias); 1 Sep 2010 20:10:58 -0000 Received: (qmail 26220 invoked by uid 22791); 1 Sep 2010 20:10:56 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 20:10:51 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o81KATCc018206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 1 Sep 2010 16:10:30 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o81KARaJ006189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Sep 2010 16:10:29 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o81KARVc031009; Wed, 1 Sep 2010 22:10:27 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o81KAPjv031003; Wed, 1 Sep 2010 22:10:25 +0200 Date: Wed, 01 Sep 2010 20:23:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Joel Brobecker , Eli Zaretskii , Mark Kettenis Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t Message-ID: <20100901201025.GA30493@host1.dyn.jankratochvil.net> References: <201009012007.55983.pedro@codesourcery.com> <20100901191843.GA27558@host1.dyn.jankratochvil.net> <201009012059.36696.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201009012059.36696.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00061.txt.bz2 On Wed, 01 Sep 2010 21:59:36 +0200, Pedro Alves wrote: > Anyway, personally, I'd just do a enum target_signal/enum gdb_signal > rename, and stay with that. I do not mind about this point, someone can post it. > But, here's another idea of how to get compiler warnings/errors, > that I think is more transparent to code throughout: > > /* An empty struct. It's the instances we care about. */ > struct gdb_signal_1 > { > }; OK, just that's a new patch. I coded this conversion to a struct just for the purpose of the patch #7. I would have never started to code that just for the purpose of a code cleanup. Now I thought it is reusable at least as a code cleanup when it is already in IMO an acceptable state. I also found as an advantage target_signal_t as a struct could get extended by additional information later, as has been done now (although unnecessarily - not completely wrongly) for siginfo, addressing the "gdb/signals.h" part: However, it is recognized that this set of signals has limitations (such as not distinguishing between various kinds of SIGSEGV, or not distinguishing hitting a breakpoint from finishing a single step). So in the future we may get around this either by adding additional signals for breakpoint, single-step, etc., or by adding signal codes; the latter seems more in the spirit of what BSD, System V, etc. are doing to address these issues. */ Therefore going to drop this part. I will repost those few fixes that have been found by this patchset. I will re-post the patch #7 as a linux-nat.c only one (as GDB is not yet ready for a regression-free gdbserver-only switch). Thanks, Jan