From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9198 invoked by alias); 1 Sep 2010 23:05:05 -0000 Received: (qmail 9189 invoked by uid 22791); 1 Sep 2010 23:05:04 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_STOCKGEN,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 23:05:02 +0000 Received: from kpbe11.cbf.corp.google.com (kpbe11.cbf.corp.google.com [172.25.105.75]) by smtp-out.google.com with ESMTP id o81N50ZY032433 for ; Wed, 1 Sep 2010 16:05:00 -0700 Received: from vws8 (vws8.prod.google.com [10.241.21.136]) by kpbe11.cbf.corp.google.com with ESMTP id o81N4wtc000855 for ; Wed, 1 Sep 2010 16:04:59 -0700 Received: by vws8 with SMTP id 8so7370838vws.30 for ; Wed, 01 Sep 2010 16:04:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.59.5 with SMTP id j5mr4517790vch.230.1283382202969; Wed, 01 Sep 2010 16:03:22 -0700 (PDT) Received: by 10.220.200.73 with HTTP; Wed, 1 Sep 2010 16:02:50 -0700 (PDT) In-Reply-To: <4C7EA94E.4010104@redhat.com> References: <4C6946E1.6000709@redhat.com> <4C6D5C83.3050602@redhat.com> <4C756132.5050301@redhat.com> <20100901082539.GA24609@host1.dyn.jankratochvil.net> <20100901161952.GX2986@adacore.com> <20100901164716.GY2986@adacore.com> <4C7E96FA.2080209@redhat.com> <4C7EA30B.7020007@redhat.com> <4C7EA94E.4010104@redhat.com> Date: Wed, 01 Sep 2010 23:16:00 -0000 Message-ID: Subject: Re: Regression for gdb.stabs/gdb11479.exp [Re: [patch 1/2] Use custom hash function with bcache] From: Doug Evans To: sami wagiaalla Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00073.txt.bz2 Message-ID: <20100901231600.yKlIJhTiTghcvS_wpVovKmyItdI9bO0ly3XnMhY_P6Y@z> On Wed, Sep 1, 2010 at 12:28 PM, sami wagiaalla wrote: >> I hope I'm not reducing the S/N ratio here, but there's something I >> don't understand. >> The original patch doesn't initialize obj_section (right?) (except by >> virtue of using "static"). =A0So if this fixes things, does it do so >> only because we're taking advantage of the fact that obj_section will >> be NULL in the static version > > Yes. > > =A0and that's sufficient? > > IIUC, it should be. > > =A0So do we need >> >> the memset of the original patch (which only zeros >> psymbol.ginfo.value). >> > > I don't really see why it is needed but I am inclined to believe the > comment. I think that stems from the old bcache-the-entire-thing-as-a-byte-array behaviour, but that's gone now (thankfully). >> Plus, reverting to the original patch leaves me a little >> uncomfortable: There's a comment that mentions gaps in the struct >> causing cache misses, but that's no longer an issue with the custom >> hash function (right?). > > I should probably fix that comment. The gabs in the struct, while bad, wo= uld > not cause hash misses since the new supplied hash function only looks at = the > initialized fields. Looking at the struct, and what's left to initialize, I like this patch. Now everything is initialized. 2010-09-01 Doug Evans * psymtab.c (add_psymbol_to_bcache): Initialize obj_section. Index: psymtab.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/psymtab.c,v retrieving revision 1.12 diff -u -p -r1.12 psymtab.c --- psymtab.c 1 Sep 2010 21:50:26 -0000 1.12 +++ psymtab.c 1 Sep 2010 22:50:05 -0000 @@ -1394,6 +1394,7 @@ add_psymbol_to_bcache (char *name, int n SYMBOL_VALUE_ADDRESS (&psymbol) =3D coreaddr; } SYMBOL_SECTION (&psymbol) =3D 0; + SYMBOL_OBJ_SECTION (&psymbol) =3D NULL; SYMBOL_SET_LANGUAGE (&psymbol, language); PSYMBOL_DOMAIN (&psymbol) =3D domain; PSYMBOL_CLASS (&psymbol) =3D class;