From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit/testsuite] Add test for -file-list-exec-source-files
Date: Thu, 02 Sep 2010 15:37:00 -0000 [thread overview]
Message-ID: <20100902152057.GM2986@adacore.com> (raw)
In-Reply-To: <20100819185432.GA10824@host1.dyn.jankratochvil.net>
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
> > I almost entirely copied the dw2-basic testcase, and just adapted it
> > loosely to do my own test rather than make a minimal one.
>
> I really do not mind as the existint gdb.dwarf2/ testcases are in many cases
> overcomplicated anyway but providing a simplified code still FAILing/PASSing
> appropriately.
:-) Thanks for doing that! I checked this testcase in as attached.
--
Joel
[-- Attachment #2: tc.diff --]
[-- Type: text/x-diff, Size: 4748 bytes --]
commit 46713d72258fedf05fb0fa3f385c42b398a3e47b
Author: Joel Brobecker <brobecker@adacore.com>
Date: Thu Aug 19 20:15:32 2010 +0200
Add test for -file-list-exec-source-files
gdb/testsuite/ChangeLog:
* gdb.dwarf/dw2-filename.S, gdb.dwarf/dw2-filename.exp: New files.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 12e33a7..084c227 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2010-09-02 Jan Kratochvil <jan.kratochvil@redhat.com>
+ Joel Brobecker <brobecker@adacore.com>
+
+ * gdb.dwarf/dw2-filename.S, gdb.dwarf/dw2-filename.exp: New files.
+
2010-08-31 Doug Evans <dje@google.com>
* gdb.dwarf2/dw4-sig-types.exp: Use .x for executable name.
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-filename.S b/gdb/testsuite/gdb.dwarf2/dw2-filename.S
new file mode 100644
index 0000000..7cac4ab
--- /dev/null
+++ b/gdb/testsuite/gdb.dwarf2/dw2-filename.S
@@ -0,0 +1,53 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2004, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+/* Debug information */
+
+ .section .debug_info
+.Lcu1_begin:
+ /* CU header */
+ .4byte .Lcu1_end - .Lcu1_start /* Length of Compilation Unit */
+.Lcu1_start:
+ .2byte 2 /* DWARF Version */
+ .4byte .Labbrev1_begin /* Offset into abbrev section */
+ .byte 4 /* Pointer size */
+
+ /* CU die */
+ .uleb128 1 /* Abbrev: DW_TAG_compile_unit */
+ .ascii "file1.txt\0" /* DW_AT_name */
+ .ascii "GNU C 3.3.3\0" /* DW_AT_producer */
+ .byte 1 /* DW_AT_language (C) */
+
+.Lcu1_end:
+
+/* Abbrev table */
+ .section .debug_abbrev
+.Labbrev1_begin:
+ .uleb128 1 /* Abbrev code */
+ .uleb128 0x11 /* DW_TAG_compile_unit */
+ .byte 0 /* has_children */
+ .uleb128 0x3 /* DW_AT_name */
+ .uleb128 0x8 /* DW_FORM_string */
+ .uleb128 0x25 /* DW_AT_producer */
+ .uleb128 0x8 /* DW_FORM_string */
+ .uleb128 0x13 /* DW_AT_language */
+ .uleb128 0xb /* DW_FORM_data1 */
+ .byte 0x0 /* Terminator */
+ .byte 0x0 /* Terminator */
+
+ .byte 0x0 /* Terminator */
+ .byte 0x0 /* Terminator */
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-filename.exp b/gdb/testsuite/gdb.dwarf2/dw2-filename.exp
new file mode 100644
index 0000000..e1afe64
--- /dev/null
+++ b/gdb/testsuite/gdb.dwarf2/dw2-filename.exp
@@ -0,0 +1,44 @@
+# Copyright 2004, 2005, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Note: Inspired from dw2-basic.exp.
+
+# This test can only be run on targets which support DWARF-2 and use gas.
+# For now pick a sampling of likely targets.
+if {![istarget *-*-linux*]
+ && ![istarget *-*-gnu*]
+ && ![istarget *-*-elf*]
+ && ![istarget *-*-openbsd*]
+ && ![istarget arm-*-eabi*]
+ && ![istarget powerpc-*-eabi*]} {
+ return 0
+}
+
+set testfile "dw2-filename"
+set srcfile ${testfile}.S
+set binfile ${objdir}/${subdir}/${testfile}.x
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" object {nodebug}] != "" } {
+ return -1
+}
+
+clean_restart ${testfile}.x
+
+# Verify that -file-list-exec-source-files returns a list where
+# the "file" is "file1.txt" (file base name), and "fullname" is
+# the full path to that file. What we want to verify, most of all,
+# is that the file and fullname fields are now inverted.
+gdb_test "interpreter-exec mi -file-list-exec-source-files" \
+ ".*{file=\"file1\\.txt\",fullname=\".+file1\\.txt\"}.*"
prev parent reply other threads:[~2010-09-02 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 9:18 [PATCH] Fix regression in -file-list-exec-source-files command Joel Brobecker
2010-08-19 10:01 ` Joel Brobecker
2010-08-19 16:35 ` Doug Evans
2010-08-19 18:35 ` [RFA/commit/testsuite] Add test for -file-list-exec-source-files Joel Brobecker
2010-08-19 18:55 ` Jan Kratochvil
2010-09-02 15:37 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902152057.GM2986@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).