From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <pedro@codesourcery.com>,
gdb-patches@sourceware.org,
Daniel Jacobowitz <dan@codesourcery.com>,
Eli Zaretskii <eliz@gnu.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
Date: Thu, 02 Sep 2010 17:04:00 -0000 [thread overview]
Message-ID: <20100902154806.GA9982@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <20100902153923.GN2986@adacore.com>
On Thu, 02 Sep 2010 17:39:23 +0200, Joel Brobecker wrote:
> > struct target_signal_o
> > {
> > int number;
> > const char *name;
> > const char *string;
> > };
[...]
> And I don't think that this is incompatible with Jan's initial goal
> of having a structure with signal and siginfo data.
It is currently incompatible as to keep it <= / >= etc. comparable it must be
kept as a pointer-to-struct, not as a struct-as-value. This approach expects
there is a finite set of predefined target_signal possibilities.
But then arbitrary set of dynamic content requires some allocate/free and/or
ref/unref. Marking all reffing/unreffing in the code is according to my
experience unmanageable.
> but if we ever change our mind again,
one day in the future GDB may already have C++ and everything will be easy.
Thanks,
Jan
next prev parent reply other threads:[~2010-09-02 15:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 7:11 Jan Kratochvil
2010-08-30 8:14 ` Mark Kettenis
2010-08-30 8:24 ` Jan Kratochvil
2010-08-30 10:09 ` Eli Zaretskii
2010-08-30 11:11 ` Mark Kettenis
2010-08-30 14:08 ` Joel Brobecker
2010-08-31 18:28 ` Jan Kratochvil
2010-08-31 18:45 ` Mark Kettenis
2010-09-01 2:03 ` Joel Brobecker
2010-09-01 18:18 ` Joel Brobecker
2010-09-01 18:30 ` Jan Kratochvil
2010-09-01 18:38 ` Pedro Alves
2010-09-01 18:45 ` Jan Kratochvil
2010-09-01 18:40 ` Joel Brobecker
2010-09-01 18:51 ` Jan Kratochvil
2010-09-01 19:08 ` Pedro Alves
2010-09-01 19:28 ` Jan Kratochvil
2010-09-01 20:06 ` Pedro Alves
2010-09-01 20:06 ` Daniel Jacobowitz
2010-09-01 20:10 ` Pedro Alves
2010-09-02 9:46 ` Pedro Alves
2010-09-02 14:01 ` Jan Kratochvil
2010-09-02 15:36 ` Joel Brobecker
2010-09-02 19:02 ` Pedro Alves
2010-09-02 20:46 ` Jan Kratochvil
2010-09-07 18:59 ` Jan Kratochvil
2010-09-02 16:02 ` Joel Brobecker
2010-09-02 17:04 ` Jan Kratochvil [this message]
2010-09-06 0:29 ` Jan Kratochvil
2010-09-06 13:30 ` Pedro Alves
2010-09-06 14:52 ` Jan Kratochvil
2010-09-08 23:42 ` Jan Kratochvil
2010-09-01 20:23 ` Jan Kratochvil
2010-09-01 20:30 ` Mark Kettenis
2010-09-01 20:47 ` Pedro Alves
2010-09-01 21:32 ` Joseph S. Myers
2010-09-01 19:12 ` Joel Brobecker
2010-09-01 22:37 ` Tom Tromey
2010-08-30 14:11 ` Eli Zaretskii
2010-08-30 17:34 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902154806.GA9982@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=dan@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).