From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28903 invoked by alias); 3 Sep 2010 01:24:43 -0000 Received: (qmail 28660 invoked by uid 9176); 3 Sep 2010 01:24:25 -0000 Date: Fri, 03 Sep 2010 07:09:00 -0000 From: GDB Administrator To: gdb-patches@sourceware.org Subject: New ARI warning Fri Sep 3 01:24:25 UTC 2010 Message-ID: <20100903012425.GA28653@sourceware.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00119.txt.bz2 32a33,35 > gdb/amd64-linux-nat.c:702: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/amd64-linux-nat.c:702:/* Get Linux/x86 target description from running target. > gdb/amd64-linux-tdep.c:337: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/amd64-linux-tdep.c:337:/* amd64_canonicalize_syscall maps from the native amd64 Linux set > gdb/amd64-linux-tdep.c:1265: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/amd64-linux-tdep.c:1265:/* Get Linux/x86 target description from core dump. */ 37a41,42 > gdb/amd64-linux-tdep.c:1545: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/amd64-linux-tdep.c:1545: /* Initialize the Linux target description */ > gdb/amd64-linux-tdep.h:34: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/amd64-linux-tdep.h:34:/* Linux target description. */ 47a53 > gdb/amd64-tdep.c:1881: deprecate: read_memory: Replace read_memory() with regcache_read() et.al. gdb/amd64-tdep.c:1881: read_memory (pc + 1, buf, 3); 67d72 < gdb/arm-linux-tdep.c:647: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-linux-tdep.c:647:arm_linux_cleanup_svc (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, 70d74 < gdb/arm-linux-tdep.c:768: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-linux-tdep.c:768:cleanup_kernel_helper_return (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, 75d78 < gdb/arm-tdep.c:564: deprecated: deprecated pc_in_call_dummy: Do not use deprecated pc_in_call_dummy, see declaration for details gdb/arm-tdep.c:564: if (deprecated_pc_in_call_dummy (gdbarch, pc)) 80,91d82 < gdb/arm-tdep.c:3349: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3349:copy_unmodified (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, < gdb/arm-tdep.c:3365: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3365:cleanup_preload (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, < gdb/arm-tdep.c:3450: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3450:cleanup_copro_load_store (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, < gdb/arm-tdep.c:3504: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3504:cleanup_branch (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, struct regcache *regs, < gdb/arm-tdep.c:3528: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3528:copy_b_bl_blx (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, < gdb/arm-tdep.c:3575: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3575:copy_bx_blx_reg (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, < gdb/arm-tdep.c:3613: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3613:cleanup_alu_imm (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, < gdb/arm-tdep.c:3674: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3674:cleanup_alu_reg (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, < gdb/arm-tdep.c:3743: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3743:cleanup_alu_shifted_reg (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, < gdb/arm-tdep.c:3817: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3817:cleanup_load (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, struct regcache *regs, < gdb/arm-tdep.c:3847: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:3847:cleanup_store (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, struct regcache *regs, < gdb/arm-tdep.c:4180: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:4180:cleanup_block_load_pc (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, 93,95d83 < gdb/arm-tdep.c:4376: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:4376:cleanup_svc (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, struct regcache *regs, < gdb/arm-tdep.c:4420: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:4420:copy_undef (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, < gdb/arm-tdep.c:4435: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB gdb/arm-tdep.c:4435:copy_unpred (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, 108a97,98 > gdb/breakpoint.c:4336: deprecate: SOLIB_ADD: Replace SOLIB_ADD with nothing, not needed? gdb/breakpoint.c:4336:#ifdef SOLIB_ADD > gdb/breakpoint.c:4337: deprecate: SOLIB_ADD: Replace SOLIB_ADD with nothing, not needed? gdb/breakpoint.c:4337: SOLIB_ADD (NULL, 0, ¤t_target, auto_solib_add); 139,140d128 < gdb/c-exp.y:2268: gettext: _ markup: All messages should be marked up with _. gdb/c-exp.y:2268: error ("Invalid character '%c' in expression.", c); < gdb/c-exp.y:2472: gettext: _ markup: All messages should be marked up with _. gdb/c-exp.y:2472: error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr); 207,209d194 < gdb/config/i386/nm-i386sol2.h:30: macro: nm CANNOT_STEP_HW_WATCHPOINTS: Do not define macros such as CANNOT_STEP_HW_WATCHPOINTS in a tm, nm or xm file, in fact do not provide a tm, nm or xm file gdb/config/i386/nm-i386sol2.h:30:#define CANNOT_STEP_HW_WATCHPOINTS < gdb/config/i386/nm-linux.h:29: macro: nm FILL_FPXREGSET: Do not define macros such as FILL_FPXREGSET in a tm, nm or xm file, in fact do not provide a tm, nm or xm file gdb/config/i386/nm-linux.h:29:#define FILL_FPXREGSET < gdb/config/nm-linux.h:24: macro: nm GET_THREAD_SIGNALS: Do not define macros such as GET_THREAD_SIGNALS in a tm, nm or xm file, in fact do not provide a tm, nm or xm file gdb/config/nm-linux.h:24:#define GET_THREAD_SIGNALS(mask) lin_thread_get_thread_signals (mask) 240a226 > gdb/cp-namespace.c:593: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/cp-namespace.c:593: sprintf (concatenated_name, ', parent_name, nested_name); 264,265d249 < gdb/defs.h:119: code: long long: Do not use 'long long', instead use LONGEST gdb/defs.h:119:#define LONGEST long long < gdb/defs.h:120: code: long long: Do not use 'long long', instead use LONGEST gdb/defs.h:120:#define ULONGEST unsigned long long 303a288,289 > gdb/dwarf2loc.c:766: deprecate: read_memory: Replace read_memory() with regcache_read() et.al. gdb/dwarf2loc.c:766: read_memory (p->v.mem.addr + dest_offset, buffer, 1); > gdb/dwarf2loc.c:767: deprecate: read_memory: Replace read_memory() with regcache_read() et.al. gdb/dwarf2loc.c:767: read_memory (p->v.mem.addr + dest_offset + this_size - 1, 420,421d405 < gdb/go32-nat.c:2050: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/go32-nat.c:2050: printf_filtered ("Page Table entry for address 0x%llx:\n", < gdb/go32-nat.c:2051: code: long long: Do not use 'long long', instead use LONGEST gdb/go32-nat.c:2051: (unsigned long long)addr); 500a485,486 > gdb/i386-linux-nat.c:907: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/i386-linux-nat.c:907:/* Get Linux/x86 target description from running target. */ > gdb/i386-linux-nat.c:952: code: long long: Do not use 'long long', instead use LONGEST gdb/i386-linux-nat.c:952: / sizeof (long long))]; 504a491,492 > gdb/i386-linux-tdep.c:619: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/i386-linux-tdep.c:619:/* Get Linux/x86 target description from core dump. */ > gdb/i386-linux-tdep.c:626: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/i386-linux-tdep.c:626: /* Linux/i386. */ 508a497,498 > gdb/i386-linux-tdep.c:915: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/i386-linux-tdep.c:915: /* Initialize the Linux target description */ > gdb/i386-linux-tdep.h:42: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/i386-linux-tdep.h:42:/* Linux target description. */ 512a503,504 > gdb/i386-tdep.c:543: deprecate: read_memory: Replace read_memory() with regcache_read() et.al. gdb/i386-tdep.c:543: read_memory (from, buf, len); > gdb/i386-tdep.c:557: deprecate: write_memory: Replace write_memory() with regcache_read() et.al. gdb/i386-tdep.c:557: write_memory (to, buf, len); 514a507 > gdb/i386-tdep.c:978: deprecate: read_memory: Replace read_memory() with regcache_read() et.al. gdb/i386-tdep.c:978: read_memory (pc + delta, buf, sizeof (buf)); 582a576,577 > gdb/infrun.c:2602: deprecated: deprecated target_wait_hook: Do not use deprecated target_wait_hook, see declaration for details gdb/infrun.c:2602: if (deprecated_target_wait_hook) > gdb/infrun.c:2604: deprecated: deprecated target_wait_hook: Do not use deprecated target_wait_hook, see declaration for details gdb/infrun.c:2604: deprecated_target_wait_hook (waiton_ptid, &ecs->ws, TARGET_WNOHANG); 590,591d584 < gdb/infrun.c:3904: deprecate: SOLIB_ADD: Replace SOLIB_ADD with nothing, not needed? gdb/infrun.c:3904: SOLIB_ADD (NULL, 0, ¤t_target, auto_solib_add); < gdb/infrun.c:4031: deprecate: SOLIB_ADD: Replace SOLIB_ADD with nothing, not needed? gdb/infrun.c:4031:#if defined(SOLIB_ADD) 655,660d647 < gdb/linespec.c:964: code: OP eol: Do not use &&, or || at the end of a line gdb/linespec.c:964: (ii = strstr (arg, ')) != NULL || < gdb/linespec.c:965: code: OP eol: Do not use &&, or || at the end of a line gdb/linespec.c:965: (ii = strstr (arg, ')) != NULL || < gdb/linespec.c:966: code: OP eol: Do not use &&, or || at the end of a line gdb/linespec.c:966: (ii = strstr (arg, ')) != NULL || < gdb/linespec.c:967: code: OP eol: Do not use &&, or || at the end of a line gdb/linespec.c:967: (ii = strstr (arg, ')) != NULL || < gdb/linespec.c:968: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this) gdb/linespec.c:968: if ((ii = strstr (arg, ')) != NULL || (ii = strstr (arg, ')) != NULL || (ii = strstr (arg, ')) != NULL || (ii = strstr (arg, ')) != NULL || (ii = strstr (arg, ')) != NULL || (ii = strstr (arg, ')) != NULL) < gdb/linespec.c:1352: code: OP eol: Do not use &&, or || at the end of a line gdb/linespec.c:1352: if (sym_class && 661a649,650 > gdb/linespec.c:1442: gettext: trailing new line: A message should not have a trailing new line gdb/linespec.c:1442: error (_("the class `%s' does not have any method instance named %s\n"), > gdb/linespec.c:1603: gettext: trailing new line: A message should not have a trailing new line gdb/linespec.c:1603: error (_("the class `%s' does not have any method instance named %s\n"), 673d661 < gdb/linux-nat.c:4056: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/linux-nat.c:4056: int ret = fscanf (mapfile, "%llx-%llx %s %llx %s %llx", 677d664 < gdb/linux-nat.c:4116: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/linux-nat.c:4116: "Save segment, %lld bytes at %s (%c%c%c)", 743,744d729 < gdb/m32c-tdep.c:2431: gettext: _ markup: All messages should be marked up with _. gdb/m32c-tdep.c:2431: error ("Cannot convert code address %s to function pointer:\n" < gdb/m32c-tdep.c:2448: gettext: _ markup: All messages should be marked up with _. gdb/m32c-tdep.c:2448: error ("Cannot convert code address %s to function pointer:\n" 818a804 > gdb/mi/mi-main.c:1121: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/mi/mi-main.c:1121: sprintf (ptr, ', (unsigned char) buffer[idx]); 826,830d811 < gdb/mi/mi-main.c:1020: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/mi/mi-main.c:1020: sprintf (ptr, ', (unsigned char) buffer[idx]); < gdb/mi/mi-main.c:1060: gettext: _ markup: All messages should be marked up with _. gdb/mi/mi-main.c:1060: error ("mi_cmd_data_write_register_values: Usage: -data-write-register-values [ ... ]"); < gdb/mi/mi-main.c:1065: gettext: _ markup: All messages should be marked up with _. gdb/mi/mi-main.c:1065: error ("mi_cmd_data_write_register_values: No registers."); < gdb/mi/mi-main.c:1068: gettext: _ markup: All messages should be marked up with _. gdb/mi/mi-main.c:1068: error ("mi_cmd_data_write_register_values: No regs and values specified."); < gdb/mi/mi-main.c:1071: gettext: _ markup: All messages should be marked up with _. gdb/mi/mi-main.c:1071: error ("mi_cmd_data_write_register_values: Regs and vals are not in pairs."); 834a816 > gdb/mi/mi-main.c:1521: deprecate: write_memory: Replace write_memory() with regcache_read() et.al. gdb/mi/mi-main.c:1521: write_memory (addr, buffer, word_size); 838d819 < gdb/mi/mi-main.c:1417: deprecate: write_memory: Replace write_memory() with regcache_read() et.al. gdb/mi/mi-main.c:1417: write_memory (addr, buffer, word_size); 844,846d824 < gdb/mi/mi-parse.c:218: gettext: _ markup: All messages should be marked up with _. gdb/mi/mi-parse.c:218: error ("Duplicate '--thread' option"); < gdb/mi/mi-parse.c:225: gettext: _ markup: All messages should be marked up with _. gdb/mi/mi-parse.c:225: error ("Duplicate '--frame' option"); < gdb/mi/mi-parse.c:233: gettext: _ markup: All messages should be marked up with _. gdb/mi/mi-parse.c:233: error ("Invalid value for the '%s' option", 1002a981 > gdb/ppc-linux-nat.c:1791: deprecated: deprecated value_modifiable: Do not use deprecated value_modifiable, see declaration for details gdb/ppc-linux-nat.c:1791: if (VALUE_LVAL (v) == not_lval || deprecated_value_modifiable (v) == 0) 1079a1059 > gdb/procfs.c:3763: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/procfs.c:3763: sprintf (name, ', pi->pid, map->pr_mapname); 1107d1086 < gdb/procfs.c:5659: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/procfs.c:5659: sprintf (name, ', pi->pid, map->pr_mapname); 1108a1088 > gdb/psymtab.c:154: code: OP eol: Do not use &&, or || at the end of a line gdb/psymtab.c:154: if (!(objfile->flags & OBJF_REORDERED) && 1110c1090,1092 < gdb/python/py-frame.c:52: gettext: _ markup: All messages should be marked up with _. gdb/python/py-frame.c:52: error ("Frame is invalid."); \ > gdb/python/py-cmd.c:192: gettext: _ markup: All messages should be marked up with _. gdb/python/py-cmd.c:192: error ("%s", msg); > gdb/python/py-inferior.c:327: deprecate: read_memory: Replace read_memory() with regcache_read() et.al. gdb/python/py-inferior.c:327: read_memory (addr, buffer, length); > gdb/python/py-inferior.c:396: deprecate: write_memory: Replace write_memory() with regcache_read() et.al. gdb/python/py-inferior.c:396: write_memory (addr, buffer, length); 1132c1114 < gdb/remote.c:439: code: OP eol: Do not use &&, or || at the end of a line gdb/remote.c:439: else if (buf[0] == '.' && > gdb/remote.c:471: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/remote.c:471: sprintf (buf, ', adjusted_size); 1143c1125,1126 < gdb/remote.c:2454: regression: strdup: Do not use strdup(), instead use xstrdup() gdb/remote.c:2454: VEC_last (thread_item_t, data->items)->extra = strdup (body_text); > gdb/remote.c:2787: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/remote.c:2787: sprintf (p, '); > gdb/remote.c:3208: gettext: _ markup: All messages should be marked up with _. gdb/remote.c:3208: error ("Remote refused setting non-stop mode with: %s", rs->buf); 1144a1128 > gdb/remote.c:3514: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/remote.c:3514: sprintf (rs->buf, ' 1165d1148 < gdb/remote.c:7594: code: OP eol: Do not use &&, or || at the end of a line gdb/remote.c:7594: if (!current_target.to_shortname || 1169a1153 > gdb/remote.c:9750: gettext: _ markup: All messages should be marked up with _. gdb/remote.c:9750: error ("Static tracepoint not valid during download"); 1182,1183c1166 < gdb/remote.c:9526: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this) gdb/remote.c:9526: if ((target_frameno = (int) strtol (++reply, &reply, 16)) == -1) < gdb/remote.c:9530: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this) gdb/remote.c:9530: if ((target_tracept = (int) strtol (++reply, &reply, 16)) == -1) > gdb/remote.c:10043: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/remote.c:10043: sprintf (rs->buf, ', tsvnum); 1191,1192d1173 < gdb/remote.h:64: deprecated: deprecated target_resume_hook: Do not use deprecated target_resume_hook, see declaration for details gdb/remote.h:64:extern void (*deprecated_target_resume_hook) (void); < gdb/remote.h:65: deprecated: deprecated target_wait_loop_hook: Do not use deprecated target_wait_loop_hook, see declaration for details gdb/remote.h:65:extern void (*deprecated_target_wait_loop_hook) (void); 1205d1185 < gdb/rs6000-nat.c:203: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/rs6000-nat.c:203: printf ("rs6000_ptrace64 (%d, %d, 0x%llx, %08x, 0x%x) = 0x%x\n", 1278,1284d1257 < gdb/sh64-tdep.c:1336: code: long long: Do not use 'long long', instead use LONGEST gdb/sh64-tdep.c:1336: (long long) get_frame_register_unsigned (frame, SR_REGNUM)); < gdb/sh64-tdep.c:1340: code: long long: Do not use 'long long', instead use LONGEST gdb/sh64-tdep.c:1340: (long long) get_frame_register_unsigned (frame, SSR_REGNUM), < gdb/sh64-tdep.c:1341: code: long long: Do not use 'long long', instead use LONGEST gdb/sh64-tdep.c:1341: (long long) get_frame_register_unsigned (frame, SPC_REGNUM)); < gdb/sh64-tdep.c:1350: code: long long: Do not use 'long long', instead use LONGEST gdb/sh64-tdep.c:1350: (long long) get_frame_register_unsigned (frame, i + 0), < gdb/sh64-tdep.c:1351: code: long long: Do not use 'long long', instead use LONGEST gdb/sh64-tdep.c:1351: (long long) get_frame_register_unsigned (frame, i + 1), < gdb/sh64-tdep.c:1352: code: long long: Do not use 'long long', instead use LONGEST gdb/sh64-tdep.c:1352: (long long) get_frame_register_unsigned (frame, i + 2), < gdb/sh64-tdep.c:1353: code: long long: Do not use 'long long', instead use LONGEST gdb/sh64-tdep.c:1353: (long long) get_frame_register_unsigned (frame, i + 3)); 1312,1322d1284 < gdb/solib-pa64.c:500: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:500: printf (" text_base = 0x%llx\n", d->text_base); < gdb/solib-pa64.c:501: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:501: printf (" text_size = 0x%llx\n", d->text_size); < gdb/solib-pa64.c:502: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:502: printf (" data_base = 0x%llx\n", d->data_base); < gdb/solib-pa64.c:503: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:503: printf (" data_size = 0x%llx\n", d->data_size); < gdb/solib-pa64.c:504: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:504: printf (" unwind_base = 0x%llx\n", d->unwind_base); < gdb/solib-pa64.c:505: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:505: printf (" linkage_ptr = 0x%llx\n", d->linkage_ptr); < gdb/solib-pa64.c:506: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:506: printf (" phdr_base = 0x%llx\n", d->phdr_base); < gdb/solib-pa64.c:507: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:507: printf (" tls_size = 0x%llx\n", d->tls_size); < gdb/solib-pa64.c:508: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:508: printf (" tls_start_addr = 0x%llx\n", d->tls_start_addr); < gdb/solib-pa64.c:509: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:509: printf (" unwind_size = 0x%llx\n", d->unwind_size); < gdb/solib-pa64.c:510: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-pa64.c:510: printf (" tls_index = 0x%llx\n", d->tls_index); 1331,1332d1292 < gdb/solib-spu.c:156: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-spu.c:156: if (sscanf (id, "0x%llx", &addr) != 1 || !addr) < gdb/solib-spu.c:164: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-spu.c:164: xsnprintf (new->so_name, sizeof new->so_name, "@0x%llx <%d>", addr, fd); 1334d1293 < gdb/solib-spu.c:203: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-spu.c:203: if (sscanf (so->so_original_name, "@0x%llx <%d>", &addr, &fd) != 2) 1336d1294 < gdb/solib-spu.c:296: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/solib-spu.c:296: if (sscanf (original_name, "@0x%llx <%d>", &addr, &fd) != 2) 1357a1316 > gdb/solib-svr4.c:295: code: UCASE function: Function name is uppercase. gdb/solib-svr4.c:295:IGNORE_FIRST_LINK_MAP_ENTRY (struct so_list *so) 1422d1380 < gdb/symfile.c:2208: deprecated: deprecated ibm6000_target: Do not use deprecated ibm6000_target, see declaration for details gdb/symfile.c:2208:#ifdef DEPRECATED_IBM6000_TARGET 1430d1387 < gdb/symtab.c:848: code: OP eol: Do not use &&, or || at the end of a line gdb/symtab.c:848: if (!(objfile->flags & OBJF_REORDERED) && 1496,1505d1452 < gdb/tracepoint.c:495: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/tracepoint.c:495: sprintf (tmpbuf, ', < gdb/tracepoint.c:500: deprecated: deprecated readline_begin_hook: Do not use deprecated readline_begin_hook, see declaration for details gdb/tracepoint.c:500: if (deprecated_readline_begin_hook) < gdb/tracepoint.c:501: deprecated: deprecated readline_begin_hook: Do not use deprecated readline_begin_hook, see declaration for details gdb/tracepoint.c:501: (*deprecated_readline_begin_hook) (', tmpbuf, end_msg); < gdb/tracepoint.c:510: deprecated: deprecated readline_end_hook: Do not use deprecated readline_end_hook, see declaration for details gdb/tracepoint.c:510: if (deprecated_readline_end_hook) < gdb/tracepoint.c:511: deprecated: deprecated readline_end_hook: Do not use deprecated readline_end_hook, see declaration for details gdb/tracepoint.c:511: (*deprecated_readline_end_hook) (); < gdb/tracepoint.c:551: deprecated: deprecated readline_hook: Do not use deprecated readline_hook, see declaration for details gdb/tracepoint.c:551: if (deprecated_readline_hook && instream == NULL) < gdb/tracepoint.c:552: deprecated: deprecated readline_hook: Do not use deprecated readline_hook, see declaration for details gdb/tracepoint.c:552: line = (*deprecated_readline_hook) (prompt); < gdb/tracepoint.c:665: code: OP eol: Do not use &&, or || at the end of a line gdb/tracepoint.c:665: if ((0 == strncasecmp (', p + 1, 3)) || < gdb/tracepoint.c:666: code: OP eol: Do not use &&, or || at the end of a line gdb/tracepoint.c:666: (0 == strncasecmp (', p + 1, 3)) || < gdb/tracepoint.c:756: code: OP eol: Do not use &&, or || at the end of a line gdb/tracepoint.c:756: if (*p == '.' || 1508a1456 > gdb/tracepoint.c:1083: gettext: trailing new line: A message should not have a trailing new line gdb/tracepoint.c:1083: warning (_("Can't collect args; no symbol table info available.\n")); 1513,1515c1461 < gdb/tracepoint.c:1281: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/tracepoint.c:1281: sprintf (default_collect_line, ', default_collect); < gdb/tracepoint.c:1542: gettext: _ markup: All messages should be marked up with _. gdb/tracepoint.c:1542: error ("No tracepoints downloaded, not starting trace"); < gdb/tracepoint.c:1649: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/tracepoint.c:1649: printf_filtered (_("Trace buffer has %llu bytes free.\n"), > gdb/tracepoint.c:1722: code: long long: Do not use 'long long', instead use LONGEST gdb/tracepoint.c:1722: ((int) ((((long long) (ts->buffer_size 1524d1469 < gdb/tracepoint.c:2403: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/tracepoint.c:2403: fprintf (fp, "status %c;%s:%x;tframes:%x;tfree:%llx\n", 1527a1473,1474 > gdb/tracepoint.c:3112: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/tracepoint.c:3112: sprintf (buf, ', namebase, try_num++); > gdb/tracepoint.c:3302: gettext: _ markup: All messages should be marked up with _. gdb/tracepoint.c:3302: warning ("No traceframes present in this file."); 1533a1481 > gdb/tracepoint.c:3975: code: OP eol: Do not use &&, or || at the end of a line gdb/tracepoint.c:3975: if ((s->flags & SEC_LOAD) == 0 || 1536,1537d1483 < gdb/tracepoint.h:100: code: long long: Do not use 'long long', instead use LONGEST gdb/tracepoint.h:100: unsigned long long buffer_size; < gdb/tracepoint.h:102: code: long long: Do not use 'long long', instead use LONGEST gdb/tracepoint.h:102: unsigned long long buffer_free; 1558d1503 < gdb/tui/tui-out.c:225: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/tui/tui-out.c:225: sprintf (buffer, ', value); 1613a1559 > gdb/valops.c:3294: code: sprintf: Do not use sprintf, instead use xstrprintf gdb/valops.c:3294: sprintf (concatenated_name, ', namespace_name, name); 1671a1618,1620 > gdb/windows-nat.c:2621: code: editCase function: Function name starts lower case but has uppercased letters. gdb/windows-nat.c:2621:bad_OpenProcessToken (HANDLE w, DWORD x, PHANDLE y) > gdb/windows-nat.c:2627: code: editCase function: Function name starts lower case but has uppercased letters. gdb/windows-nat.c:2627:bad_GetCurrentConsoleFont (HANDLE w, BOOL bMaxWindow, CONSOLE_FONT_INFO *f) > gdb/windows-nat.c:2633: code: editCase function: Function name starts lower case but has uppercased letters. gdb/windows-nat.c:2633:bad_GetConsoleFontSize (HANDLE w, DWORD nFont) 1711d1659 < gdb/utils.c:0: internal: gdb/utils.c missing abort: Expecting 4 occurances of bug abort in file gdb/utils.c, only found 3 gdb/utils.c:0: