From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22975 invoked by alias); 3 Sep 2010 15:42:38 -0000 Received: (qmail 22957 invoked by uid 22791); 3 Sep 2010 15:42:37 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Sep 2010 15:42:30 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o83FgLw9001448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 Sep 2010 11:42:21 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o83FgJwe020459 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 3 Sep 2010 11:42:20 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o83FgJ7U005121; Fri, 3 Sep 2010 17:42:19 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o83FgITl005119; Fri, 3 Sep 2010 17:42:18 +0200 Date: Fri, 03 Sep 2010 18:01:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, pebolle@tiscali.nl Subject: Re: [patch] Fix nesting of ui_out_redirect Message-ID: <20100903154218.GA5060@host1.dyn.jankratochvil.net> References: <20100903112139.GA20855@host1.dyn.jankratochvil.net> <201009031404.23364.pedro@codesourcery.com> <20100903152332.GA30657@host1.dyn.jankratochvil.net> <201009031633.23542.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201009031633.23542.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00130.txt.bz2 On Fri, 03 Sep 2010 17:33:23 +0200, Pedro Alves wrote: > On Friday 03 September 2010 16:23:32, Jan Kratochvil wrote: > > > gdb/ > > 2010-09-03 Jan Kratochvil > > > > * breakpoint.c (save_breakpoints): Use RETURN_MASK_ALL. > > * cli-out.c: Include vec.h. > > (cli_field_fmt, cli_spaces, cli_text, cli_message, cli_flush): New > > variable stream, initialize it, use it. > > (cli_redirect): New function comment. Replace the stream and > > original_stream fields by the new streams field. Remove the > > original_stream != NULL conditional, assert error on NULL instead. > > (out_field_fmt, field_separator): New variable stream, initialize it, use it. > > (cli_out_data_ctor): Assert non-NULL stream. Replace the stream and > > original_stream fields by the new streams field. > > (cli_out_set_stream): Replace the stream field by the new streams > > field. > > * cli-out.h: Include vec.h. > > (ui_filep): New typedef, call DEF_VEC_P for it. > > (struct cli_ui_out_data): Replace the stream and original_stream > > fields by the new streams field. > > * cli/cli-logging.c (set_logging_redirect): Call ui_out_redirect with > > NULL first. Extend the comment. > > (handle_redirections): Call ui_out_redirect with output. > > * python/py-breakpoint.c (bppy_get_commands): Move ui_out_redirect > > calls outside of the TRY_CATCH block. > > > > gdb/testsuite/ > > 2010-09-03 Jan Kratochvil > > > > * gdb.base/ui-redirect.exp: New file. > > Okay. Checked-in: http://sourceware.org/ml/gdb-cvs/2010-09/msg00031.html Thanks, Jan