public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: FYI: change type searching
Date: Mon, 06 Sep 2010 08:55:00 -0000	[thread overview]
Message-ID: <20100904224448.GH28036@caradoc.them.org> (raw)
In-Reply-To: <m3wrr59m1v.fsf@fleche.redhat.com>

On Wed, Sep 01, 2010 at 03:43:56PM -0600, Tom Tromey wrote:
> I'm checking this in.

Did you test this using GCC 4.5?  It appears to regress temargs.exp.
Specifically, this bit:

> @@ -1051,7 +1051,7 @@ lookup_typename (const struct language_defn *language,
>    struct symbol *sym;
>    struct type *tmp;
>  
> -  sym = lookup_symbol (name, block, VAR_DOMAIN, 0);
> +  sym = lookup_type_symbol (name, block, VAR_DOMAIN, language->la_language);
>    if (sym == NULL || SYMBOL_CLASS (sym) != LOC_TYPEDEF)
>      {
>        tmp = language_lookup_primitive_type_by_name (language, gdbarch, name);

lookup_symbol can find the Base<....> type.  lookup_type_symbol does
not find it.

> All of this searching is pointless, though, because types are made
> static, not public.

I don't know what you mean by this.  If you mean in our symbol lists,
then that's not true; C++ types go in the global list.

-- 
Daniel Jacobowitz
CodeSourcery

  reply	other threads:[~2010-09-04 22:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 22:22 Tom Tromey
2010-09-06  8:55 ` Daniel Jacobowitz [this message]
2010-09-08 17:15   ` Tom Tromey
2010-09-08 17:52     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100904224448.GH28036@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).