From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25383 invoked by alias); 4 Sep 2010 22:44:59 -0000 Received: (qmail 25375 invoked by uid 22791); 4 Sep 2010 22:44:58 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 04 Sep 2010 22:44:54 +0000 Received: (qmail 24439 invoked from network); 4 Sep 2010 22:44:52 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Sep 2010 22:44:52 -0000 Date: Mon, 06 Sep 2010 08:55:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: FYI: change type searching Message-ID: <20100904224448.GH28036@caradoc.them.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00144.txt.bz2 On Wed, Sep 01, 2010 at 03:43:56PM -0600, Tom Tromey wrote: > I'm checking this in. Did you test this using GCC 4.5? It appears to regress temargs.exp. Specifically, this bit: > @@ -1051,7 +1051,7 @@ lookup_typename (const struct language_defn *language, > struct symbol *sym; > struct type *tmp; > > - sym = lookup_symbol (name, block, VAR_DOMAIN, 0); > + sym = lookup_type_symbol (name, block, VAR_DOMAIN, language->la_language); > if (sym == NULL || SYMBOL_CLASS (sym) != LOC_TYPEDEF) > { > tmp = language_lookup_primitive_type_by_name (language, gdbarch, name); lookup_symbol can find the Base<....> type. lookup_type_symbol does not find it. > All of this searching is pointless, though, because types are made > static, not public. I don't know what you mean by this. If you mean in our symbol lists, then that's not true; C++ types go in the global list. -- Daniel Jacobowitz CodeSourcery