From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Yao Qi <yao@codesourcery.com>
Subject: Re: [gdbserver] Remove unused variables
Date: Mon, 06 Sep 2010 10:45:00 -0000 [thread overview]
Message-ID: <201009061046.06062.pedro@codesourcery.com> (raw)
In-Reply-To: <4C7F7273.6090708@codesourcery.com>
On Thursday 02 September 2010 10:46:27, Yao Qi wrote:
> Hi,
> This patch is to remove unused variables in order to fix some build
> failures I find today on GDB CVS HEAD.
(...)
Most of the patch is okay, except:
> if (debug_threads)
> fprintf (stderr, "lk_1: killing lwp %ld, for pid: %d\n",
> @@ -1201,9 +1199,6 @@ linux_fast_tracepoint_collecting (struct
> static int
> maybe_move_out_of_jump_pad (struct lwp_info *lwp, int *wstat)
> {
> - struct thread_info *saved_inferior;
> -
> - saved_inferior = current_inferior;
> current_inferior = get_lwp_thread (lwp);
... this bit, that revealed a bug. saved_inferior should be used. Please
add a "current_inferior = saved_inferior;" statement before
every return path in this function instead. Bonus points
if you do that in a separate patch from the "remove unused
variables" one.
--
Pedro Alves
next prev parent reply other threads:[~2010-09-06 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 14:00 Yao Qi
2010-09-06 10:45 ` Pedro Alves [this message]
2010-09-06 15:22 ` Yao Qi
2010-09-06 15:49 ` Pedro Alves
2010-09-06 22:29 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009061046.06062.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).