From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Paralkar Anmol-B07584" <B07584@freescale.com>,
"Michael Snyder" <msnyder@vmware.com>,
"Medve Emilian-EMMEDVE1" <EMMEDVE1@freescale.com>
Subject: Re: Fix for: "/usr/bin/install: cannot stat `libinproctrace.so': No such file or directory"
Date: Mon, 06 Sep 2010 11:57:00 -0000 [thread overview]
Message-ID: <201009061145.48280.pedro@codesourcery.com> (raw)
In-Reply-To: <95944E5A981ABF4A872A89BF855D4BA605C24E87@az33exm21>
On Thursday 02 September 2010 23:12:46, Paralkar Anmol-B07584 wrote:
> Hello Michael,
>
> Sorry! Please see the (attached) re-spun patch.
Hi! Thanks for spotting this.
> *************** install: all install-only
> *** 167,173 ****
> install-only:
> n=`echo gdbserver | sed '$(program_transform_name)'`; \
> if [ x$$n = x ]; then n=gdbserver; else true; fi; \
> ! if [ x$IPA_DEPFILES != x ]; then \
> $(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir); \
> $(INSTALL_PROGRAM) $(IPA_LIB) $(DESTDIR)$(libdir)/$(IPA_LIB); \
> fi; \
> --- 167,173 ----
> install-only:
> n=`echo gdbserver | sed '$(program_transform_name)'`; \
> if [ x$$n = x ]; then n=gdbserver; else true; fi; \
> ! if [ x$$IPA_DEPFILES != x ]; then \
> $(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir); \
> $(INSTALL_PROGRAM) $(IPA_LIB) $(DESTDIR)$(libdir)/$(IPA_LIB); \
> fi; \
This however isn't correct. The intent is not to make the variable reference visible
to the shell (it'd always be empty), but to expand it before the shell sees it.
I've applied this patch below to fix this, after confirming "make install" does install
the library on a amd64-linux build. I'll apply this to the 7.2 branch as well shortly.
2010-09-06 Pedro Alves <pedro@codesourcery.com>
* Makefile.in (install-only): Replace $IPA_DEPFILES with
"$(IPA_DEPFILES)".
---
gdb/gdbserver/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: src/gdb/gdbserver/Makefile.in
===================================================================
--- src.orig/gdb/gdbserver/Makefile.in 2010-09-06 11:28:19.000000000 +0100
+++ src/gdb/gdbserver/Makefile.in 2010-09-06 11:42:54.000000000 +0100
@@ -167,7 +167,7 @@ install: all install-only
install-only:
n=`echo gdbserver | sed '$(program_transform_name)'`; \
if [ x$$n = x ]; then n=gdbserver; else true; fi; \
- if [ x$IPA_DEPFILES != x ]; then \
+ if [ x"$(IPA_DEPFILES)" != x ]; then \
$(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir); \
$(INSTALL_PROGRAM) $(IPA_LIB) $(DESTDIR)$(libdir)/$(IPA_LIB); \
fi; \
prev parent reply other threads:[~2010-09-06 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 23:20 Anmol P. Paralkar
2010-09-02 23:33 ` Michael Snyder
2010-09-02 23:49 ` Paralkar Anmol-B07584
2010-09-06 11:57 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009061145.48280.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=B07584@freescale.com \
--cc=EMMEDVE1@freescale.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).