From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24890 invoked by alias); 6 Sep 2010 10:45:56 -0000 Received: (qmail 24881 invoked by uid 22791); 6 Sep 2010 10:45:55 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Sep 2010 10:45:51 +0000 Received: (qmail 9880 invoked from network); 6 Sep 2010 10:45:49 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Sep 2010 10:45:49 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Fix for: "/usr/bin/install: cannot stat `libinproctrace.so': No such file or directory" Date: Mon, 06 Sep 2010 11:57:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: "Paralkar Anmol-B07584" , "Michael Snyder" , "Medve Emilian-EMMEDVE1" References: <4C800D2F.1010702@vmware.com> <95944E5A981ABF4A872A89BF855D4BA605C24E87@az33exm21> In-Reply-To: <95944E5A981ABF4A872A89BF855D4BA605C24E87@az33exm21> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201009061145.48280.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00151.txt.bz2 On Thursday 02 September 2010 23:12:46, Paralkar Anmol-B07584 wrote: > Hello Michael, > > Sorry! Please see the (attached) re-spun patch. Hi! Thanks for spotting this. > *************** install: all install-only > *** 167,173 **** > install-only: > n=`echo gdbserver | sed '$(program_transform_name)'`; \ > if [ x$$n = x ]; then n=gdbserver; else true; fi; \ > ! if [ x$IPA_DEPFILES != x ]; then \ > $(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir); \ > $(INSTALL_PROGRAM) $(IPA_LIB) $(DESTDIR)$(libdir)/$(IPA_LIB); \ > fi; \ > --- 167,173 ---- > install-only: > n=`echo gdbserver | sed '$(program_transform_name)'`; \ > if [ x$$n = x ]; then n=gdbserver; else true; fi; \ > ! if [ x$$IPA_DEPFILES != x ]; then \ > $(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir); \ > $(INSTALL_PROGRAM) $(IPA_LIB) $(DESTDIR)$(libdir)/$(IPA_LIB); \ > fi; \ This however isn't correct. The intent is not to make the variable reference visible to the shell (it'd always be empty), but to expand it before the shell sees it. I've applied this patch below to fix this, after confirming "make install" does install the library on a amd64-linux build. I'll apply this to the 7.2 branch as well shortly. 2010-09-06 Pedro Alves * Makefile.in (install-only): Replace $IPA_DEPFILES with "$(IPA_DEPFILES)". --- gdb/gdbserver/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/gdbserver/Makefile.in =================================================================== --- src.orig/gdb/gdbserver/Makefile.in 2010-09-06 11:28:19.000000000 +0100 +++ src/gdb/gdbserver/Makefile.in 2010-09-06 11:42:54.000000000 +0100 @@ -167,7 +167,7 @@ install: all install-only install-only: n=`echo gdbserver | sed '$(program_transform_name)'`; \ if [ x$$n = x ]; then n=gdbserver; else true; fi; \ - if [ x$IPA_DEPFILES != x ]; then \ + if [ x"$(IPA_DEPFILES)" != x ]; then \ $(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir); \ $(INSTALL_PROGRAM) $(IPA_LIB) $(DESTDIR)$(libdir)/$(IPA_LIB); \ fi; \