From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3771 invoked by alias); 6 Sep 2010 11:57:29 -0000 Received: (qmail 3763 invoked by uid 22791); 6 Sep 2010 11:57:29 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Sep 2010 11:57:23 +0000 Received: (qmail 21225 invoked from network); 6 Sep 2010 11:57:21 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Sep 2010 11:57:21 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH,ARM] Fix single step on vfork Date: Mon, 06 Sep 2010 14:09:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Yao Qi References: <4C7E85C0.3050902@codesourcery.com> <201009011811.10735.pedro@codesourcery.com> <4C7EF7F9.8040709@codesourcery.com> In-Reply-To: <4C7EF7F9.8040709@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201009061257.20113.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00154.txt.bz2 On Thursday 02 September 2010 02:03:53, Yao Qi wrote: > Pedro Alves wrote: > > On Wednesday 01 September 2010 17:56:32, Yao Qi wrote: > >> + /* Don't consider single-stepping when the inferior is > >> + waiting_for_vfork_done, either software or hardware step. In > >> + software step, child process will hit the software single step > >> + breakpoint inserted in parent process. In hardware step, GDB > >> + can resumes inferior, and waiting for vfork_done event. */ > > > > This last sentence looks incomplete? At least, I can't seem to > > parse it. > > > I replaced "waiting" by "wait" in the new patch. Thanks. Please go ahead with your patch. Hope you don't mind I tweak the comment a bit afterwards. -- Pedro Alves