From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] testsuite: sigall.exp: Fix false FAILs
Date: Mon, 13 Sep 2010 08:28:00 -0000 [thread overview]
Message-ID: <20100912133113.GA21299@host1.dyn.jankratochvil.net> (raw)
Hi,
if your sourcetree topdir contains a substring "kill" then while still:
make check RUNTESTFLAGS=gdb.base/sigall.exp
# of expected passes 380
the other case starts FAILing:
make check//unix RUNTESTFLAGS=gdb.base/sigall.exp
# of expected passes 290
# of unexpected failures 90
It is due to a false catch in the second case:
Breakpoint 61, gen_WAITING () at /home/jkratoch/redhat/gdb-test-dir-kill/gdb/testsuite/gdb.base/sigall.c:1136^M
1136 handle_WAITING (0);^M
which is not a problem in the first case:
Breakpoint 61, gen_WAITING () at ./gdb.base/sigall.c:1136^M
1136 handle_WAITING (0);^M
The two lines being matched look always like:
826 kill (getpid (), SIGILL);^M
839 handle_EMT (0);^M
Tested on x86_64-fedora14snapshot-linux-gnu.
Going to check it in in some days as obvious.
Thanks,
Jan
gdb/testsuite/
2010-09-12 Jan Kratochvil <jan.kratochvil@redhat.com>
Fix false FAILs on sourcetree topdir directory containing "kill".
* gdb.base/sigall.exp (test_one_sig) <advance to $nextsig>: Extend the
source line matching regexp.
--- a/gdb/testsuite/gdb.base/sigall.exp
+++ b/gdb/testsuite/gdb.base/sigall.exp
@@ -94,11 +94,11 @@ proc test_one_sig {nextsig} {
if { $missed_handler == "0" } then {
gdb_test_multiple "signal 0" "advance to $nextsig" {
- -re "Breakpoint.*gen_$nextsig.*kill.*$gdb_prompt $" {
+ -re "Breakpoint.*gen_$nextsig.*\r\n\[0-9\]+\[ \t\]+kill \\(.*\r\n$gdb_prompt $" {
pass "advance to $nextsig"
set sig_supported 1
}
- -re "Breakpoint.*gen_$nextsig.*handle.*$gdb_prompt $" {
+ -re "Breakpoint.*gen_$nextsig.*\r\n\[0-9\]+\[ \t\]+handle_.*\r\n$gdb_prompt $" {
pass "advance to $nextsig"
set sig_supported 0
}
next reply other threads:[~2010-09-12 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 8:28 Jan Kratochvil [this message]
2010-09-13 19:15 ` Joel Brobecker
2010-09-14 8:02 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100912133113.GA21299@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).