public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>,
	Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [RFA/commit] DWARF: Add support for DW_TAG_constant DIEs
Date: Fri, 17 Sep 2010 13:11:00 -0000	[thread overview]
Message-ID: <201009171021.20811.pedro@codesourcery.com> (raw)
In-Reply-To: <20100916204350.GL3845@adacore.com>

On Thursday 16 September 2010 21:43:50, Joel Brobecker wrote:
> +
> +       if (pdi->is_external)
> +         list = &objfile->global_psymbols;
> +       else
> +         list = &objfile->static_psymbols,

Comma operator alert.                       ^

> +       psym = add_psymbol_to_list (actual_name, strlen (actual_name),
> +                                   built_actual_name, VAR_DOMAIN, LOC_STATIC,
> +                                   list, 0, 0, cu->language, objfile);

-- 
Pedro Alves

  reply	other threads:[~2010-09-17  9:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16 21:31 Joel Brobecker
2010-09-16 22:23 ` Nathan Froyd
2010-09-16 22:29   ` Joel Brobecker
2010-09-17 13:11     ` Pedro Alves [this message]
2010-09-19 23:02 ` Jan Kratochvil
2010-09-21 18:41   ` Joel Brobecker
2010-09-21 19:43     ` Jan Kratochvil
2010-09-22 18:43       ` Joel Brobecker
2010-09-22 19:42         ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009171021.20811.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=froydnj@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).