From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27070 invoked by alias); 20 Sep 2010 16:25:47 -0000 Received: (qmail 27057 invoked by uid 22791); 20 Sep 2010 16:25:46 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Sep 2010 16:25:41 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8KGPQQL012915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 20 Sep 2010 12:25:26 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8KGPOPn025146 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Sep 2010 12:25:26 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o8KGPN1p027159; Mon, 20 Sep 2010 18:25:23 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o8KGPM0Y027154; Mon, 20 Sep 2010 18:25:22 +0200 Date: Tue, 21 Sep 2010 19:43:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] DWARF: Add support for DW_TAG_constant DIEs Message-ID: <20100920162522.GA26738@host1.dyn.jankratochvil.net> References: <1284668546-25877-1-git-send-email-brobecker@adacore.com> <20100919173918.GA29737@host1.dyn.jankratochvil.net> <20100920160844.GN3845@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100920160844.GN3845@adacore.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00348.txt.bz2 On Mon, 20 Sep 2010 18:08:44 +0200, Joel Brobecker wrote: > As explained in my original email - I felt at the time that this would > make the DW_TAG_variable case overly complicated, whereas I did not see > why DW_TAG_constant would need more than what I added. If we prefer to > merge the two, I'm happy too. I just wanted to help keep things as > simple as possible. What do you think? I got it now - I had the bug you describe in the patch of mine. I am also in favor of your simplified code case. Thanks, Jan