From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [PING]RE: [RFA] Fix maint translate command
Date: Wed, 22 Sep 2010 19:23:00 -0000 [thread overview]
Message-ID: <201009221959.03816.pedro@codesourcery.com> (raw)
In-Reply-To: <20100922170111.GE3063@adacore.com>
On Wednesday 22 September 2010 18:01:11, Joel Brobecker wrote:
> On Tue, Sep 14, 2010 at 10:10:02AM +0200, Pierre Muller wrote:
> > The problem of break inside ALL_OBJSECTIONS
> > is still not fixed on CVS despite a fix proposed by Pedro?
> >
> > I must confess that I am unable to fully understand such complicated
> > macros, and I leave to others the responsibility to
> > approve such kind of patches (I don't have any rights on
> > objfiles sources anyhow ...)
> >
> > Would it be possible to check Pedro's patch in?
>
> Seems like everyone is really really busy these days :-(.
Indeed. :-(
> This is coming from Pedro, and I didn't see anything wrong with it.
> Since we haven't received any objection, I think it is fine to commit
> after running it against the testsuite.
I'll test&apply this tomorrow. Sorry for the delay.
> > > > I admit it loop ugly, and that may look complicated, but it isn't
> > > > (complicated). The outer loop learns about the inner loop's end
> > > > condition, and stops iterating if it detects the inner loop didn't
> > > > reach it's end. The trick to not clearing "objfile" is to only
> > > > advance it in the outer loop, if the inner loop reached it's end.
>
> I think that this is a useful comment to add to the macro. And perhaps
> explain that the purpose is to allow `break' to exit the ALL_OBJSECTIONS
> (double-) loop.
I'll extend the current comment in that direction.
--
Pedro Alves
next prev parent reply other threads:[~2010-09-22 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 8:54 Pierre Muller
2010-09-01 13:39 ` Pedro Alves
2010-09-01 13:49 ` Pierre Muller
2010-09-01 15:25 ` Pedro Alves
2010-09-01 16:07 ` Pedro Alves
2010-09-14 15:14 ` [PING]RE: " Pierre Muller
2010-09-22 18:59 ` Joel Brobecker
2010-09-22 19:23 ` Pedro Alves [this message]
2010-09-24 15:55 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009221959.03816.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).