From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [PING]RE: [RFA] Fix maint translate command
Date: Fri, 24 Sep 2010 15:55:00 -0000 [thread overview]
Message-ID: <201009241225.05267.pedro@codesourcery.com> (raw)
In-Reply-To: <201009221959.03816.pedro@codesourcery.com>
On Wednesday 22 September 2010 19:59:03, Pedro Alves wrote:
> On Wednesday 22 September 2010 18:01:11, Joel Brobecker wrote:
> > I think that this is a useful comment to add to the macro. And perhaps
> > explain that the purpose is to allow `break' to exit the ALL_OBJSECTIONS
> > (double-) loop.
>
> I'll extend the current comment in that direction.
Done now. Tested on x86_64-unknown-linux-gnu and applied.
--
Pedro Alves
2010-09-24 Pedro Alves <pedro@codesourcery.com>
* objfiles.h (ALL_OBJSECTIONS): Handle breaks in the inner loop.
---
gdb/objfiles.h | 41 ++++++++++++++++++++++++++++++++++++++---
1 file changed, 38 insertions(+), 3 deletions(-)
Index: src/gdb/objfiles.h
===================================================================
--- src.orig/gdb/objfiles.h 2010-09-24 10:22:44.000000000 +0100
+++ src/gdb/objfiles.h 2010-09-24 11:32:44.000000000 +0100
@@ -611,9 +611,44 @@ extern int gdb_bfd_close_or_warn (struct
#define ALL_OBJFILE_OSECTIONS(objfile, osect) \
for (osect = objfile->sections; osect < objfile->sections_end; osect++)
-#define ALL_OBJSECTIONS(objfile, osect) \
- ALL_OBJFILES (objfile) \
- ALL_OBJFILE_OSECTIONS (objfile, osect)
+/* Traverse all obj_sections in all objfiles in the current program
+ space.
+
+ Note that this detects a "break" in the inner loop, and exits
+ immediately from the outer loop as well, thus, client code doesn't
+ need to know that this is implemented with a double for. The extra
+ hair is to make sure that a "break;" stops the outer loop iterating
+ as well, and both OBJFILE and OSECT are left unmodified:
+
+ - The outer loop learns about the inner loop's end condition, and
+ stops iterating if it detects the inner loop didn't reach its
+ end. In other words, the outer loop keeps going only if the
+ inner loop reached its end cleanly [(osect) ==
+ (objfile)->sections_end].
+
+ - OSECT is initialized in the outer loop initialization
+ expressions, such as if the inner loop has reached its end, so
+ the check mentioned above succeeds the first time.
+
+ - The trick to not clearing OBJFILE on a "break;" is, in the outer
+ loop's loop expression, advance OBJFILE, but iff the inner loop
+ reached its end. If not, there was a "break;", so leave OBJFILE
+ as is; the outer loop's conditional will break immediately as
+ well (as OSECT will be different from OBJFILE->sections_end).
+*/
+
+#define ALL_OBJSECTIONS(objfile, osect) \
+ for ((objfile) = current_program_space->objfiles, \
+ (objfile) != NULL ? ((osect) = (objfile)->sections_end) : 0; \
+ (objfile) != NULL \
+ && (osect) == (objfile)->sections_end; \
+ ((osect) == (objfile)->sections_end \
+ ? ((objfile) = (objfile)->next, \
+ (objfile) != NULL ? (osect) = (objfile)->sections_end : 0) \
+ : 0)) \
+ for ((osect) = (objfile)->sections; \
+ (osect) < (objfile)->sections_end; \
+ (osect)++)
#define SECT_OFF_DATA(objfile) \
((objfile->sect_index_data == -1) \
prev parent reply other threads:[~2010-09-24 11:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 8:54 Pierre Muller
2010-09-01 13:39 ` Pedro Alves
2010-09-01 13:49 ` Pierre Muller
2010-09-01 15:25 ` Pedro Alves
2010-09-01 16:07 ` Pedro Alves
2010-09-14 15:14 ` [PING]RE: " Pierre Muller
2010-09-22 18:59 ` Joel Brobecker
2010-09-22 19:23 ` Pedro Alves
2010-09-24 15:55 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009241225.05267.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).