From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Ken Werner <ken@linux.vnet.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [patch] const array types
Date: Fri, 24 Sep 2010 16:27:00 -0000 [thread overview]
Message-ID: <20100924144234.GF3007@adacore.com> (raw)
In-Reply-To: <20100923223709.GA25145@host1.dyn.jankratochvil.net>
> I have filed now http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45765 as
> I believe it could be fixed more at the DWARF producer side.
For what it's worth, I tend to agree that this should be fixed
on the compiler side.
> I would find this patch OK even if it fixes only the TYPE_CODE_ARRAY.
I'm a little hesitant, still (but not objecting!). It it was a one-liner,
I'd be less reluctant, but I just want to make sure that the improvement
is worth the code we're adding. Yes, the output is more accurate, but
is it really all that bad to be missing the `const'?
> > + make_cv_type (1, TYPE_VOLATILE (el_type), el_type, 0);
> ^ NULL?
> I would find NULL for a pointer parameter more readable.
I agree.
--
Joel
next prev parent reply other threads:[~2010-09-24 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 19:32 Ken Werner
2010-09-24 4:50 ` Jan Kratochvil
2010-09-24 15:38 ` Jan Kratochvil
2010-09-24 16:27 ` Joel Brobecker [this message]
2010-09-24 16:40 ` Pedro Alves
2010-09-24 23:00 ` Joel Brobecker
2010-09-24 18:36 ` Ken Werner
2010-10-05 18:25 ` Ulrich Weigand
2010-10-05 18:43 ` Joel Brobecker
2010-10-06 15:38 ` Ken Werner
2010-10-06 15:55 ` Ulrich Weigand
2010-10-06 16:18 ` Ken Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100924144234.GF3007@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=ken@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).