From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31566 invoked by alias); 27 Sep 2010 17:43:51 -0000 Received: (qmail 31556 invoked by uid 22791); 27 Sep 2010 17:43:50 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Sep 2010 17:43:44 +0000 Received: (qmail 32600 invoked from network); 27 Sep 2010 17:43:42 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Sep 2010 17:43:42 -0000 From: Pedro Alves To: Joel Brobecker Subject: Re: [PATCH 2/2] Add support for GNAT Ravenscar run-time library. Date: Mon, 27 Sep 2010 19:01:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org References: <1285267380-8329-1-git-send-email-brobecker@adacore.com> <201009232308.50387.pedro@codesourcery.com> <20100927173414.GH3007@adacore.com> In-Reply-To: <20100927173414.GH3007@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201009271843.40237.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00455.txt.bz2 Hi Joel, This is close, but, On Monday 27 September 2010 18:34:14, Joel Brobecker wrote: > @@ -282,6 +286,7 @@ ravenscar_mourn_inferior (struct target_ops *ops) > base_ptid = null_ptid; > beneath->to_mourn_inferior (beneath); > unpush_target (&ravenscar_ops); > + ravenscar_is_open = 0; > } I'd prefer that a ranvenscar target_ops->to_close callback was implemented, so that if the target ends up closed without going through mourn_inferior (some paths do that presently): static void ravenscar_close (int quitting) { ranvenscar_is_open = 0; } See for example bsd-uthreads.c:bfd_uthread_close, or remote-sim.c:gdbsim_close. This is fine with me with that change. -- Pedro Alves