* New ARI warning Wed Sep 29 01:54:08 UTC 2010
@ 2010-09-29 13:34 GDB Administrator
2010-09-29 18:55 ` Joel Brobecker
0 siblings, 1 reply; 4+ messages in thread
From: GDB Administrator @ 2010-09-29 13:34 UTC (permalink / raw)
To: gdb-patches
1096a1097,1099
> gdb/ravenscar-sparc-thread.c:71: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
gdb/ravenscar-sparc-thread.c:71: read_memory (register_addr, buf, buf_size);
> gdb/ravenscar-sparc-thread.c:173: deprecate: write_memory: Replace write_memory() with regcache_read() et.al.
gdb/ravenscar-sparc-thread.c:173: write_memory (register_address,
> gdb/ravenscar-thread.c:156: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
gdb/ravenscar-thread.c:156: read_memory (object_addr, buf, buf_size);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New ARI warning Wed Sep 29 01:54:08 UTC 2010
2010-09-29 13:34 New ARI warning Wed Sep 29 01:54:08 UTC 2010 GDB Administrator
@ 2010-09-29 18:55 ` Joel Brobecker
2010-09-29 22:25 ` Pedro Alves
0 siblings, 1 reply; 4+ messages in thread
From: Joel Brobecker @ 2010-09-29 18:55 UTC (permalink / raw)
To: gdb-patches
> 1096a1097,1099
> > gdb/ravenscar-sparc-thread.c:71: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
> gdb/ravenscar-sparc-thread.c:71: read_memory (register_addr, buf, buf_size);
> > gdb/ravenscar-sparc-thread.c:173: deprecate: write_memory: Replace write_memory() with regcache_read() et.al.
> gdb/ravenscar-sparc-thread.c:173: write_memory (register_address,
> > gdb/ravenscar-thread.c:156: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
> gdb/ravenscar-thread.c:156: read_memory (object_addr, buf, buf_size);
I can fix the warnings, but are we really planning on removing
read/write_memory (and why?). I can use target_read_memory instead,
but I don't get the suggestion about regcache_read...
--
Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New ARI warning Wed Sep 29 01:54:08 UTC 2010
2010-09-29 18:55 ` Joel Brobecker
@ 2010-09-29 22:25 ` Pedro Alves
2010-09-30 1:36 ` Joel Brobecker
0 siblings, 1 reply; 4+ messages in thread
From: Pedro Alves @ 2010-09-29 22:25 UTC (permalink / raw)
To: gdb-patches; +Cc: Joel Brobecker
On Wednesday 29 September 2010 17:32:47, Joel Brobecker wrote:
> > 1096a1097,1099
> > > gdb/ravenscar-sparc-thread.c:71: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
> > gdb/ravenscar-sparc-thread.c:71: read_memory (register_addr, buf, buf_size);
> > > gdb/ravenscar-sparc-thread.c:173: deprecate: write_memory: Replace write_memory() with regcache_read() et.al.
> > gdb/ravenscar-sparc-thread.c:173: write_memory (register_address,
> > > gdb/ravenscar-thread.c:156: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
> > gdb/ravenscar-thread.c:156: read_memory (object_addr, buf, buf_size);
>
> I can fix the warnings, but are we really planning on removing
> read/write_memory (and why?). I can use target_read_memory instead,
> but I don't get the suggestion about regcache_read...
The ARI suggestion makes no sense. It's the ARI that needs fixing.
My guess is that the intention was to suggest replacing
read_register() with regcache_read() at.al. (that is, s/memory/register)
read_register/write_register have been yanked out from the sources
already few years ago.
--
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New ARI warning Wed Sep 29 01:54:08 UTC 2010
2010-09-29 22:25 ` Pedro Alves
@ 2010-09-30 1:36 ` Joel Brobecker
0 siblings, 0 replies; 4+ messages in thread
From: Joel Brobecker @ 2010-09-30 1:36 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
> The ARI suggestion makes no sense. It's the ARI that needs fixing.
That's what I was thinking too.
> My guess is that the intention was to suggest replacing
> read_register() with regcache_read() at.al. (that is, s/memory/register)
> read_register/write_register have been yanked out from the sources
> already few years ago.
That makes sense.
I have modified the ARI script accordingly, and rerun it, in order
to expunge the references to read_memory in the reference report.
The two extra emails we should get shortly from gdbadmin should reflect
these changes.
Thanks,
--
Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-29 18:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-29 13:34 New ARI warning Wed Sep 29 01:54:08 UTC 2010 GDB Administrator
2010-09-29 18:55 ` Joel Brobecker
2010-09-29 22:25 ` Pedro Alves
2010-09-30 1:36 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).