New ARI warning Wed Sep 29 01:54:08 UTC 2010

New ARI warning Wed Sep 29 01:54:08 UTC 2010

[GDB Administrator]

1096a1097,1099
> gdb/ravenscar-sparc-thread.c:71: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
gdb/ravenscar-sparc-thread.c:71:  read_memory (register_addr, buf, buf_size);
> gdb/ravenscar-sparc-thread.c:173: deprecate: write_memory: Replace write_memory() with regcache_read() et.al.
gdb/ravenscar-sparc-thread.c:173:  write_memory (register_address,
> gdb/ravenscar-thread.c:156: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
gdb/ravenscar-thread.c:156:  read_memory (object_addr, buf, buf_size);

Re: New ARI warning Wed Sep 29 01:54:08 UTC 2010

[Joel Brobecker]

> 1096a1097,1099
> > gdb/ravenscar-sparc-thread.c:71: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
> gdb/ravenscar-sparc-thread.c:71:  read_memory (register_addr, buf, buf_size);
> > gdb/ravenscar-sparc-thread.c:173: deprecate: write_memory: Replace write_memory() with regcache_read() et.al.
> gdb/ravenscar-sparc-thread.c:173:  write_memory (register_address,
> > gdb/ravenscar-thread.c:156: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
> gdb/ravenscar-thread.c:156:  read_memory (object_addr, buf, buf_size);

I can fix the warnings, but are we really planning on removing
read/write_memory (and why?). I can use target_read_memory instead,
but I don't get the suggestion about regcache_read...

-- 
Joel

Re: New ARI warning Wed Sep 29 01:54:08 UTC 2010

[Pedro Alves]

On Wednesday 29 September 2010 17:32:47, Joel Brobecker wrote:
> > 1096a1097,1099
> > > gdb/ravenscar-sparc-thread.c:71: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
> > gdb/ravenscar-sparc-thread.c:71:  read_memory (register_addr, buf, buf_size);
> > > gdb/ravenscar-sparc-thread.c:173: deprecate: write_memory: Replace write_memory() with regcache_read() et.al.
> > gdb/ravenscar-sparc-thread.c:173:  write_memory (register_address,
> > > gdb/ravenscar-thread.c:156: deprecate: read_memory: Replace read_memory() with regcache_read() et.al.
> > gdb/ravenscar-thread.c:156:  read_memory (object_addr, buf, buf_size);
> 
> I can fix the warnings, but are we really planning on removing
> read/write_memory (and why?). I can use target_read_memory instead,
> but I don't get the suggestion about regcache_read...

The ARI suggestion makes no sense.  It's the ARI that needs fixing.
My guess is that the intention was to suggest replacing
read_register() with regcache_read() at.al.  (that is, s/memory/register)
read_register/write_register have been yanked out from the sources
already few years ago.

-- 
Pedro Alves

Re: New ARI warning Wed Sep 29 01:54:08 UTC 2010

[Joel Brobecker]

> The ARI suggestion makes no sense.  It's the ARI that needs fixing.

That's what I was thinking too.

> My guess is that the intention was to suggest replacing
> read_register() with regcache_read() at.al.  (that is, s/memory/register)
> read_register/write_register have been yanked out from the sources
> already few years ago.

That makes sense.

I have modified the ARI script accordingly, and rerun it, in order
to expunge the references to read_memory in the reference report.
The two extra emails we should get shortly from gdbadmin should reflect
these changes.

Thanks,
-- 
Joel