From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: ken@linux.vnet.ibm.com (Ken Werner)
Cc: jan.kratochvil@redhat.com (Jan Kratochvil),
gdb-patches@sourceware.org, brobecker@adacore.com,
pedro@codesourcery.com
Subject: Re: [patch] const array types
Date: Tue, 05 Oct 2010 18:25:00 -0000 [thread overview]
Message-ID: <201010051825.o95IP5I8010642@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <201009241755.15373.ken@linux.vnet.ibm.com> from "Ken Werner" at Sep 24, 2010 05:55:15 PM
Ken Werner wrote:
> + return set_die_type (die, base_type, cu);;
Extra semicolon.
> local_compiler_xfail_check
> + gdb_test "ptype logical" "type = const char \\\[2\\\]"
> + gdb_test "ptype lugged" "type = const unsigned char \\\[2\\\]"
> + gdb_test "ptype luck" "type = const short( int)? \\\[2\\\]"
> + gdb_test "ptype lunar" "type = const (unsigned short|short unsigned)( int)? \\\[2\\\]"
> + gdb_test "ptype lumen" "type = const long( int)? \\\[2\\\]"
> + gdb_test "ptype lurk" "type = const (unsigned long|long unsigned)( int)? \\\[2\\\]"
> + gdb_test "ptype lush" "type = const float \\\[2\\\]"
> + gdb_test "ptype lynx" "type = const double \\\[2\\\]"
Do we need the local_compiler_xfail_check for these tests? If so, we'd need
it before each of the tests; if not, we don't need it at all ...
Otherwise, this patch looks good to me.
Joel, if I followed the discussion correctly, you still had some concerns;
have they been resolved now?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2010-10-05 18:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 19:32 Ken Werner
2010-09-24 4:50 ` Jan Kratochvil
2010-09-24 15:38 ` Jan Kratochvil
2010-09-24 16:27 ` Joel Brobecker
2010-09-24 16:40 ` Pedro Alves
2010-09-24 23:00 ` Joel Brobecker
2010-09-24 18:36 ` Ken Werner
2010-10-05 18:25 ` Ulrich Weigand [this message]
2010-10-05 18:43 ` Joel Brobecker
2010-10-06 15:38 ` Ken Werner
2010-10-06 15:55 ` Ulrich Weigand
2010-10-06 16:18 ` Ken Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010051825.o95IP5I8010642@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=ken@linux.vnet.ibm.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).