From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25938 invoked by alias); 5 Oct 2010 18:25:16 -0000 Received: (qmail 25928 invoked by uid 22791); 5 Oct 2010 18:25:15 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.17.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Oct 2010 18:25:10 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.1/8.13.1) with ESMTP id o95IP7Pu003521 for ; Tue, 5 Oct 2010 18:25:07 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o95IP7or4018410 for ; Tue, 5 Oct 2010 20:25:07 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o95IP6WE010649 for ; Tue, 5 Oct 2010 20:25:06 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o95IP5I8010642; Tue, 5 Oct 2010 20:25:05 +0200 Message-Id: <201010051825.o95IP5I8010642@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 05 Oct 2010 20:25:05 +0200 Subject: Re: [patch] const array types To: ken@linux.vnet.ibm.com (Ken Werner) Date: Tue, 05 Oct 2010 18:25:00 -0000 From: "Ulrich Weigand" Cc: jan.kratochvil@redhat.com (Jan Kratochvil), gdb-patches@sourceware.org, brobecker@adacore.com, pedro@codesourcery.com In-Reply-To: <201009241755.15373.ken@linux.vnet.ibm.com> from "Ken Werner" at Sep 24, 2010 05:55:15 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00049.txt.bz2 Ken Werner wrote: > + return set_die_type (die, base_type, cu);; Extra semicolon. > local_compiler_xfail_check > + gdb_test "ptype logical" "type = const char \\\[2\\\]" > + gdb_test "ptype lugged" "type = const unsigned char \\\[2\\\]" > + gdb_test "ptype luck" "type = const short( int)? \\\[2\\\]" > + gdb_test "ptype lunar" "type = const (unsigned short|short unsigned)( int)? \\\[2\\\]" > + gdb_test "ptype lumen" "type = const long( int)? \\\[2\\\]" > + gdb_test "ptype lurk" "type = const (unsigned long|long unsigned)( int)? \\\[2\\\]" > + gdb_test "ptype lush" "type = const float \\\[2\\\]" > + gdb_test "ptype lynx" "type = const double \\\[2\\\]" Do we need the local_compiler_xfail_check for these tests? If so, we'd need it before each of the tests; if not, we don't need it at all ... Otherwise, this patch looks good to me. Joel, if I followed the discussion correctly, you still had some concerns; have they been resolved now? Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com