* [RFA] Quiet a tracepoint notification with gdbserver
@ 2010-10-08 17:41 Daniel Jacobowitz
2010-10-08 17:49 ` Michael Snyder
2010-10-08 18:52 ` Stan Shebs
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Jacobowitz @ 2010-10-08 17:41 UTC (permalink / raw)
To: gdb-patches; +Cc: Stan Shebs, Pedro Alves
Since gdbserver now defines trace_timestamp, we get a notice after
connection. This is confusing if you're not trying to use
tracepoints. I suggest the attached patch; OK?
--
Daniel Jacobowitz
CodeSourcery
2010-10-08 Daniel Jacobowitz <dan@codesourcery.com>
* tracepoint.c (merge_uploaded_trace_state_variables): Only print
messages if info_verbose.
Index: tracepoint.c
===================================================================
--- tracepoint.c (revision 301900)
+++ tracepoint.c (working copy)
@@ -3139,13 +3139,17 @@ merge_uploaded_trace_state_variables (st
{
tsv = find_matching_tsv (utsv);
if (tsv)
- printf_filtered (_("Assuming trace state variable $%s is same as target's variable %d.\n"),
- tsv->name, utsv->number);
+ {
+ if (info_verbose)
+ printf_filtered (_("Assuming trace state variable $%s is same as target's variable %d.\n"),
+ tsv->name, utsv->number);
+ }
else
{
tsv = create_tsv_from_upload (utsv);
- printf_filtered (_("Created trace state variable $%s for target's variable %d.\n"),
- tsv->name, utsv->number);
+ if (info_verbose)
+ printf_filtered (_("Created trace state variable $%s for target's variable %d.\n"),
+ tsv->name, utsv->number);
}
/* Give precedence to numberings that come from the target. */
if (tsv)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Quiet a tracepoint notification with gdbserver
2010-10-08 17:41 [RFA] Quiet a tracepoint notification with gdbserver Daniel Jacobowitz
@ 2010-10-08 17:49 ` Michael Snyder
2010-10-08 18:52 ` Stan Shebs
1 sibling, 0 replies; 4+ messages in thread
From: Michael Snyder @ 2010-10-08 17:49 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
Daniel Jacobowitz wrote:
> Since gdbserver now defines trace_timestamp, we get a notice after
> connection. This is confusing if you're not trying to use
> tracepoints. I suggest the attached patch; OK?
>
Thank you! I've found those messages bothersome, not because they
confuse me but because they will confuse my users.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Quiet a tracepoint notification with gdbserver
2010-10-08 17:41 [RFA] Quiet a tracepoint notification with gdbserver Daniel Jacobowitz
2010-10-08 17:49 ` Michael Snyder
@ 2010-10-08 18:52 ` Stan Shebs
2010-10-08 20:45 ` Daniel Jacobowitz
1 sibling, 1 reply; 4+ messages in thread
From: Stan Shebs @ 2010-10-08 18:52 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches, Stan Shebs, Pedro Alves
Daniel Jacobowitz wrote:
> Since gdbserver now defines trace_timestamp, we get a notice after
> connection. This is confusing if you're not trying to use
> tracepoints. I suggest the attached patch; OK?
>
>
It's OK with me. I think what we really want is some kind of "I'm a
tracepoint user" hint or heuristic that activates this class of warning,
but we don't yet have enough user feedback to know how much effort we
need to make.
Stan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Quiet a tracepoint notification with gdbserver
2010-10-08 18:52 ` Stan Shebs
@ 2010-10-08 20:45 ` Daniel Jacobowitz
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Jacobowitz @ 2010-10-08 20:45 UTC (permalink / raw)
To: Stan Shebs; +Cc: gdb-patches, Pedro Alves
On Fri, Oct 08, 2010 at 11:52:21AM -0700, Stan Shebs wrote:
> Daniel Jacobowitz wrote:
> >Since gdbserver now defines trace_timestamp, we get a notice after
> >connection. This is confusing if you're not trying to use
> >tracepoints. I suggest the attached patch; OK?
> >
>
> It's OK with me.
Thanks, checked in.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-08 20:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-08 17:41 [RFA] Quiet a tracepoint notification with gdbserver Daniel Jacobowitz
2010-10-08 17:49 ` Michael Snyder
2010-10-08 18:52 ` Stan Shebs
2010-10-08 20:45 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).