From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9544 invoked by alias); 18 Oct 2010 08:51:57 -0000 Received: (qmail 9532 invoked by uid 22791); 18 Oct 2010 08:51:55 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Oct 2010 08:51:50 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9I8pgHe029640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 18 Oct 2010 04:51:42 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o9I8peRq019728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 18 Oct 2010 04:51:42 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o9I8pdEE025829; Mon, 18 Oct 2010 10:51:39 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o9I8pcCY025817; Mon, 18 Oct 2010 10:51:38 +0200 Date: Mon, 18 Oct 2010 08:51:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [rfc] linux-nat: Never PTRACE_CONT a stepping thread Message-ID: <20101018085138.GA25628@host1.dyn.jankratochvil.net> References: <20100921234325.GA31267@host1.dyn.jankratochvil.net> <201010161809.53308.pedro@codesourcery.com> <20101017182745.GA9936@host1.dyn.jankratochvil.net> <201010172004.18986.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201010172004.18986.pedro@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00283.txt.bz2 On Sun, 17 Oct 2010 21:04:18 +0200, Pedro Alves wrote: > I just belatedly realized that this probably > breaks software single-step archs though. :-/ I have run the testsuite on arm-fedora12-linux-gnu and the only regression-candidate there is gdb.threads/local-watch-wrong-thread.exp . But that one is reproducible even on x86_64-fedora14snapshot-linux-gnu just by `set can-use-hw-watchpoints 0'. That testcase in fact should not have executed on arm due to: if [target_info exists gdb,no_hardware_watchpoints] { return 0; } Checking more why that change happened. I do not see why it should fail in general. insert_single_step_breakpoint already supports two existing single step breakpoints, one gets used for inferior_ptid and one for stepping ptid. Maybe the support of two single step breakpoints is there for some inferior code constructs, in such case I understand two would be no longer enough. Thanks, Jan