From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18623 invoked by alias); 18 Oct 2010 21:20:05 -0000 Received: (qmail 18615 invoked by uid 22791); 18 Oct 2010 21:20:04 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Oct 2010 21:19:58 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9ILJu7i010657 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 18 Oct 2010 17:19:56 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o9ILJr63010543 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 18 Oct 2010 17:19:55 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o9ILJr4A017122; Mon, 18 Oct 2010 23:19:53 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o9ILJqUH017121; Mon, 18 Oct 2010 23:19:52 +0200 Date: Mon, 18 Oct 2010 21:20:00 -0000 From: Jan Kratochvil To: Andrew Burgess Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Multi-dimensional Fortran arrays issue PR11104 Message-ID: <20101018211952.GA16206@host1.dyn.jankratochvil.net> References: <89AE14E37D740B4796DC14566DF6325ECB7E173182@SJEXCHCCR02.corp.ad.broadcom.com> <89AE14E37D740B4796DC14566DF6325ECB7F0C2B39@SJEXCHCCR02.corp.ad.broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89AE14E37D740B4796DC14566DF6325ECB7F0C2B39@SJEXCHCCR02.corp.ad.broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00287.txt.bz2 On Mon, 18 Oct 2010 09:53:03 +0200, Andrew Burgess wrote: > Was wondering if there was anything else I should do to get this patch > considered for inclusion? I'm happy to make any changes required; this is my > first gdb patch. multi-dim.tar.bz2 (.exp + .f90) should be submitted as a normal patch, you can at least do `diff -u /dev/null gdb/testsuite/gdb.fortran/file.exp'. ChangeLog should be submitted as a text, not as patch. There are several minor issues with formatting: http://www.gnu.org/prep/standards/ (I have not yet checked the real code of the patch.) This functionality is implemented by archer-jankratochvil-vla from: http://sourceware.org/gdb/wiki/ArcherBranchManagement (out of bounds access is not detected by the VLA patchset though) which is currently not submitted for a review as it has more prerequisites. Regards, Jan