From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: Don't warn if target reports no threads
Date: Tue, 19 Oct 2010 15:01:00 -0000 [thread overview]
Message-ID: <201010191601.26042.pedro@codesourcery.com> (raw)
In-Reply-To: <201010191852.03421.vladimir@codesourcery.com>
On Tuesday 19 October 2010 15:52:03, Vladimir Prus wrote:
>
> In the case when stub refuses to understand all modern thread-listing packets,
> GDB falls back to qL packet, if if stub refuses to handle that either,
> reports:
>
> RMT ERROR : failed to get remote thread list.
>
> The further operation continues normally, and qL is really optional packet, so
> there's no point scaring a user like that. Is the patch below OK?
remote_get_threadlist has this:
getpkt (&rs->buf, &rs->buf_size, 0);
if (*rs->buf == '\0')
*result_count = 0;
else
...
would it work to just make that:
if (*rs->buf == '\0')
return 0;
instead? That'd be easier to read, and leave the warning if
something did go bust with the thread listing for targets
that do support the packet (not sure there are any though).
--
Pedro Alves
next prev parent reply other threads:[~2010-10-19 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 14:52 Vladimir Prus
2010-10-19 15:01 ` Pedro Alves [this message]
2010-10-20 9:11 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010191601.26042.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).