From: Vladimir Prus <vladimir@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Don't warn if target reports no threads
Date: Wed, 20 Oct 2010 09:11:00 -0000 [thread overview]
Message-ID: <201010201311.24935.vladimir@codesourcery.com> (raw)
In-Reply-To: <201010191601.26042.pedro@codesourcery.com>
[-- Attachment #1: Type: Text/Plain, Size: 1010 bytes --]
On Tuesday, October 19, 2010 19:01:25 Pedro Alves wrote:
> On Tuesday 19 October 2010 15:52:03, Vladimir Prus wrote:
> > In the case when stub refuses to understand all modern thread-listing
> > packets, GDB falls back to qL packet, if if stub refuses to handle that
> > either,
> >
> > reports:
> > RMT ERROR : failed to get remote thread list.
> >
> > The further operation continues normally, and qL is really optional
> > packet, so there's no point scaring a user like that. Is the patch below
> > OK?
>
> remote_get_threadlist has this:
>
> getpkt (&rs->buf, &rs->buf_size, 0);
>
> if (*rs->buf == '\0')
> *result_count = 0;
> else
> ...
>
> would it work to just make that:
>
> if (*rs->buf == '\0')
> return 0;
>
> instead? That'd be easier to read, and leave the warning if
> something did go bust with the thread listing for targets
> that do support the packet (not sure there are any though).
This appears to work just fine. I've checked in the below patch.
- Volodya
[-- Attachment #2: ql.diff --]
[-- Type: text/x-patch, Size: 1125 bytes --]
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.12274
diff -u -p -r1.12274 ChangeLog
--- ChangeLog 19 Oct 2010 21:30:53 -0000 1.12274
+++ ChangeLog 20 Oct 2010 09:10:22 -0000
@@ -1,3 +1,9 @@
+2010-10-20 Vladimir Prus <vladimir@codesourcery.com>
+
+ * remote.c (remote_get_threadlist): If we got empty
+ response, bail out immediately, and don't emit any
+ warnings.
+
2010-10-19 Ulrich Weigand <uweigand@de.ibm.com>
* arm-tdep.c (thumb_get_next_pc_raw): Handle Thumb-16 encoding
Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.422
diff -u -p -r1.422 remote.c
--- remote.c 17 Oct 2010 18:24:47 -0000 1.422
+++ remote.c 20 Oct 2010 09:10:23 -0000
@@ -2353,7 +2353,7 @@ remote_get_threadlist (int startflag, th
getpkt (&rs->buf, &rs->buf_size, 0);
if (*rs->buf == '\0')
- *result_count = 0;
+ return 0;
else
*result_count =
parse_threadlist_response (rs->buf + 2, result_limit, &echo_nextthread,
prev parent reply other threads:[~2010-10-20 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 14:52 Vladimir Prus
2010-10-19 15:01 ` Pedro Alves
2010-10-20 9:11 ` Vladimir Prus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010201311.24935.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).