From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix avoiding of unnecessary psymtabs in dwarf_decode_lines
Date: Tue, 26 Oct 2010 13:39:00 -0000 [thread overview]
Message-ID: <20101026133928.GB2847@adacore.com> (raw)
In-Reply-To: <20100825000001.9D9A484B8E@ruffy.mtv.corp.google.com>
[I am soooo far behind on gdb patches :-(]
> + file_is_pst = strcmp (include_name_to_compare, pst_filename) == 0;
I know that the original code was already using strcmp to do the
comparison, but shouldn't we be using FILENAME_CMP instead. That should
take care of platforms where the filesystem is case insensitive...
Since the patch was sent so long ago, I can make the change and do
the testing, if people agree.
--
Joel
next prev parent reply other threads:[~2010-10-26 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 0:00 Doug Evans
2010-10-26 13:39 ` Joel Brobecker [this message]
2010-10-26 15:36 ` [RFA/commit] replace strcmp by FILENAME_CMP for filename comparison Joel Brobecker
2010-10-26 18:02 ` Joel Brobecker
2010-10-26 15:37 ` [patch] Fix avoiding of unnecessary psymtabs in dwarf_decode_lines Tom Tromey
2010-10-26 17:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026133928.GB2847@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).