From: Daniel Jacobowitz <dan@codesourcery.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, rearnsha@arm.com
Subject: Re: [rfa] Detect __aeabi_read_tp even without symbols
Date: Tue, 26 Oct 2010 15:17:00 -0000 [thread overview]
Message-ID: <20101026151740.GA28684@caradoc.them.org> (raw)
In-Reply-To: <201010200002.o9K02VsX019850@d12av02.megacenter.de.ibm.com>
On Wed, Oct 20, 2010 at 02:02:31AM +0200, Ulrich Weigand wrote:
> OK for mainline?
The approach looks good to me. Two comments on the implementation:
the explanation is just as valid in the ARM case as the Thumb case,
and we should not do this read if we know the name of the target
function and it is different from __aeabi_read_tp. Both of these can
be accomplished by putting the check in skip_prologue_function
instead.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-10-26 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 0:02 Ulrich Weigand
2010-10-26 15:17 ` Daniel Jacobowitz [this message]
2010-12-01 16:05 ` [rfa v2] " Ulrich Weigand
2010-12-06 21:50 ` Daniel Jacobowitz
2011-01-11 17:59 ` [ping] " Ulrich Weigand
2011-02-02 19:50 ` Ulrich Weigand
2010-10-31 15:49 ` [rfa] " Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026151740.GA28684@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=rearnsha@arm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).