On Tuesday, October 26, 2010 10:03:26 pm Joel Brobecker wrote:
> > I have a few comments, and I feel like most of the changes except maybe
> > the ones in c-exp.y can go in without a followup review.

Thanks for your review! Attached is revised patch that incorporates fixes for 
the issues you mentioned.

> Just to clarify a bit what I was trying to say: Most of the comments are
> mostly cosmetic, and I don't think we need to verify that you followed
> the comments correctly. If this was the only comments I had, I would be
> comfortable with pre-approving the patch, particularly since Tom already
> looked at it as well.  But before the patch goes in, I'd like to understand
> what the reason for the changes in c-exp.y...

The reason for looking up the primitive types instead of referring to the 
builtins is that the builtin types may have a wrong type size. The OpenCL type 
long for example is expected to have a size of 8 byte while the size of the 
GDB builtin long is dependant on the current architecture and might be only 4 
bytes.

Regards
Ken