From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76217-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16840 invoked by alias); 27 Oct 2010 19:04:59 -0000
Received: (qmail 16753 invoked by uid 22791); 27 Oct 2010 19:04:57 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Oct 2010 19:04:46 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9RJ4LpS027813	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 27 Oct 2010 15:04:21 -0400
Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id o9RJ4IFP032596	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Wed, 27 Oct 2010 15:04:20 -0400
Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1])	by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o9RJ4Iam019330;	Wed, 27 Oct 2010 21:04:18 +0200
Received: (from jkratoch@localhost)	by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o9RJ4Hig019329;	Wed, 27 Oct 2010 15:04:17 -0400
Date: Wed, 27 Oct 2010 19:04:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Ken Werner <ken@linux.vnet.ibm.com>, Tom Tromey <tromey@redhat.com>,        gdb-patches@sourceware.org
Subject: Re: [patch] initial OpenCL C language support
Message-ID: <20101027190417.GA19067@host1.dyn.jankratochvil.net>
References: <201010221920.30046.ken@linux.vnet.ibm.com> <201010261505.07587.ken@linux.vnet.ibm.com> <m3aam1oyjk.fsf@fleche.redhat.com> <201010261800.43899.ken@linux.vnet.ibm.com> <20101026195747.GE2847@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101026195747.GE2847@adacore.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-10/txt/msg00382.txt.bz2

On Tue, 26 Oct 2010 15:57:47 -0400, Joel Brobecker wrote:
> > +      ret = ! value_equal (val1, val2);
>               ^^^^^ extra space

GNU Coding Standards contains only this reference to the ! operator:
       if (! fp)

(GDB code contains enough of both cases.)


Regards,
Jan