From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76218-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20979 invoked by alias); 27 Oct 2010 19:21:03 -0000
Received: (qmail 20971 invoked by uid 22791); 27 Oct 2010 19:21:03 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Oct 2010 19:20:57 +0000
Received: (qmail 27929 invoked from network); 27 Oct 2010 19:20:56 -0000
Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 27 Oct 2010 19:20:56 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] initial OpenCL C language support
Date: Wed, 27 Oct 2010 19:21:00 -0000
User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; )
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, Joel Brobecker <brobecker@adacore.com>, Ken Werner <ken@linux.vnet.ibm.com>, Tom Tromey <tromey@redhat.com>
References: <201010221920.30046.ken@linux.vnet.ibm.com> <20101026195747.GE2847@adacore.com> <20101027190417.GA19067@host1.dyn.jankratochvil.net>
In-Reply-To: <20101027190417.GA19067@host1.dyn.jankratochvil.net>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201010272020.51386.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-10/txt/msg00383.txt.bz2

On Wednesday 27 October 2010 20:04:17, Jan Kratochvil wrote:
> On Tue, 26 Oct 2010 15:57:47 -0400, Joel Brobecker wrote:
> > > +      ret = ! value_equal (val1, val2);
> >               ^^^^^ extra space
> 
> GNU Coding Standards contains only this reference to the ! operator:
>        if (! fp)
> 
> (GDB code contains enough of both cases.)

GCC makes that rule explicit:

http://gcc.gnu.org/codingconventions.html

<quote>
Code in GCC should use the following formatting conventions: 
Use...                     ...instead of
!x                         ! x
~x                         ~ x
-x (unary minus)           - x
(foo) x (cast)             (foo)x
*x (pointer dereference)   * x
</quote>

We tend to follow these already, so I'm of the opinion we should
make them explictily official in gdb too.

-- 
Pedro Alves