From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 734 invoked by alias); 27 Oct 2010 21:01:20 -0000 Received: (qmail 720 invoked by uid 22791); 27 Oct 2010 21:01:19 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate2.uk.ibm.com (HELO mtagate2.uk.ibm.com) (194.196.100.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Oct 2010 21:01:14 +0000 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o9RL1BfE003762 for ; Wed, 27 Oct 2010 21:01:11 GMT Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o9RL1CTn3625108 for ; Wed, 27 Oct 2010 22:01:12 +0100 Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o9RL1AUi013685 for ; Wed, 27 Oct 2010 15:01:11 -0600 Received: from leonard.localnet (ICON-9-167-217-83.megacenter.de.ibm.com [9.167.217.83]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id o9RL16AY013323 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 27 Oct 2010 15:01:10 -0600 From: Ken Werner To: Pedro Alves Subject: Re: [patch] initial OpenCL C language support Date: Wed, 27 Oct 2010 21:01:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-22-generic-pae; KDE/4.5.1; i686; ; ) Cc: Jan Kratochvil , Joel Brobecker , Tom Tromey , gdb-patches@sourceware.org References: <201010221920.30046.ken@linux.vnet.ibm.com> <20101027190417.GA19067@host1.dyn.jankratochvil.net> <201010272020.51386.pedro@codesourcery.com> In-Reply-To: <201010272020.51386.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201010272301.05902.ken@linux.vnet.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00384.txt.bz2 On Wednesday, October 27, 2010 9:20:50 pm Pedro Alves wrote: > On Wednesday 27 October 2010 20:04:17, Jan Kratochvil wrote: > > On Tue, 26 Oct 2010 15:57:47 -0400, Joel Brobecker wrote: > > > > + ret = ! value_equal (val1, val2); > > > > > > > ^^^^^ extra space > > > > GNU Coding Standards contains only this reference to the ! operator: > > if (! fp) > > > > (GDB code contains enough of both cases.) > > GCC makes that rule explicit: > > http://gcc.gnu.org/codingconventions.html > > > Code in GCC should use the following formatting conventions: > Use... ...instead of > !x ! x > ~x ~ x > -x (unary minus) - x > (foo) x (cast) (foo)x > *x (pointer dereference) * x > > > We tend to follow these already, so I'm of the opinion we should > make them explictily official in gdb too. Ok, thanks for clarifying. I have changed the code to look like this: case BINOP_NOTEQUAL: ret = !value_equal (val1, val2); Regards Ken