From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15034 invoked by alias); 2 Nov 2010 18:09:28 -0000 Received: (qmail 15023 invoked by uid 22791); 2 Nov 2010 18:09:27 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 18:09:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 67B242BACA9; Tue, 2 Nov 2010 14:09:20 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Vf-gJlySGEaq; Tue, 2 Nov 2010 14:09:20 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 23C2B2BAB2E; Tue, 2 Nov 2010 14:09:19 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 22492F588F; Tue, 2 Nov 2010 11:09:12 -0700 (PDT) Date: Tue, 02 Nov 2010 18:09:00 -0000 From: Joel Brobecker To: Nathan Froyd Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] fix disassembly of E500 instructions Message-ID: <20101102180912.GC2492@adacore.com> References: <1288380041-22124-1-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1288380041-22124-1-git-send-email-froydnj@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00033.txt.bz2 > * rs6000-tdep.c (gdb_print_insn_powerpc): Disassemble e500 > instructions if debugging an e500 binary. This seems OK to me, but I think it would be useful to embed your description in the code as a comment: > This patch addresses a usability nit: when debugging E500 binaries and > disassembling code containing E500-specific (SPE) instructions, one > sometimes sees AltiVec instructions instead. The opcode spaces for SPE > instructions and AltiVec instructions overlap, and specifiying the "any" > cpu in gdb_print_insn_powerpc looks for AltiVec instructions first. If > we know we're debugging an E500 binary, however, we can specify the > "e500x2" cpu and get much more sane disassembly output. -- Joel