From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16464 invoked by alias); 2 Nov 2010 18:10:58 -0000 Received: (qmail 16129 invoked by uid 22791); 2 Nov 2010 18:10:56 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_FN,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 18:10:51 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA2IAJY7027693 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Nov 2010 14:10:19 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oA2IAEHM004516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 2 Nov 2010 14:10:18 -0400 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oA2IA9FW025294; Tue, 2 Nov 2010 19:10:10 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oA2IA3xT025293; Tue, 2 Nov 2010 19:10:03 +0100 Date: Tue, 02 Nov 2010 18:10:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Doug Evans , gdb-patches@sourceware.org, Ken Werner , Tom Tromey , Pedro Alves Subject: Re: [doc RFA] Switch to GCC coding style Message-ID: <20101102181003.GA25177@host0.dyn.jankratochvil.net> References: <201010221920.30046.ken@linux.vnet.ibm.com> <20101026195747.GE2847@adacore.com> <20101027190417.GA19067@host1.dyn.jankratochvil.net> <201010272020.51386.pedro@codesourcery.com> <20101102165134.GA19296@host0.dyn.jankratochvil.net> <20101102180110.GB2492@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101102180110.GB2492@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00034.txt.bz2 On Tue, 02 Nov 2010 19:01:10 +0100, Joel Brobecker wrote: > > There are lots of things on the gcc codingconventions page that need > > to be converted (e.g., gcc_assert), or revised (e.g., prototypes for > > _initialize_foo fns can appear in .c files (and should *only* appear > > in .c files)). > > > > I'm not sure, but it might be simpler to just copy over the relevant bits. > > This is something I was thinking about as well. I think we should have > our own Wiki page for conventions. That way, we can document our own > specific requirements (gdb_assert, etc). The current code is not strictly compliant to any standard anyway. And I do not think GDB wants to needlessly diverge from GCC on GCC Conventions updates in the future. These were the reasons why I prefer just referencing GCC Conventions. Thanks, Jan