From: Joel Brobecker <brobecker@adacore.com>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] initial OpenCL C language support
Date: Wed, 03 Nov 2010 15:27:00 -0000 [thread overview]
Message-ID: <20101103152723.GA2445@adacore.com> (raw)
In-Reply-To: <201011031402.40132.ken@linux.vnet.ibm.com>
> In case of C (and probably Ada as well) the lengths of the builtin
> types depend on the architecuter/implementation but for OpenCL C it's
> kind of the other way round. I hard coded the lengths because OpenCL
> specifies fixed sizes of the builtin types:
> http://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/scalarDataTypes.html
> http://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/vectorDataTypes.html
> Does this sound reasonable?
It took me a while to understand the distinction in the GDB code
between builtin types and primitive types, but I get it, now, and
I understand the reason for the changes - thank you!
Patch looks good to me, at this point. It needs documentation
(doc/gdb.texinfo) and a NEWS entry. Can you send a separate patch
for this portion. Once the documentation is approved, you may commit
this patch as well.
Thank you,
--
Joel
next prev parent reply other threads:[~2010-11-03 15:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 17:21 Ken Werner
2010-10-25 22:41 ` Tom Tromey
2010-10-26 13:05 ` Ken Werner
2010-10-26 13:44 ` Tom Tromey
2010-10-26 16:02 ` Ken Werner
2010-10-26 17:49 ` Eli Zaretskii
2010-10-26 19:58 ` Joel Brobecker
2010-10-26 20:03 ` Joel Brobecker
2010-10-27 13:36 ` Ken Werner
2010-11-02 19:23 ` Joel Brobecker
2010-11-03 13:03 ` Ken Werner
2010-11-03 15:27 ` Joel Brobecker [this message]
2010-11-04 15:39 ` Ken Werner
2010-11-04 17:48 ` Eli Zaretskii
2010-11-05 14:21 ` Ken Werner
2010-11-05 14:39 ` Ken Werner
2010-10-27 19:04 ` Jan Kratochvil
2010-10-27 19:21 ` Pedro Alves
2010-10-27 21:01 ` Ken Werner
2010-11-02 16:52 ` [doc RFA] Switch to GCC coding style [Re: [patch] initial OpenCL C language support] Jan Kratochvil
2010-11-02 17:04 ` Doug Evans
2010-11-02 17:23 ` Jan Kratochvil
2010-11-02 17:29 ` Doug Evans
2010-11-02 19:21 ` Eli Zaretskii
2010-11-02 19:29 ` Joel Brobecker
2010-11-08 12:50 ` Jan Kratochvil
2010-11-08 16:11 ` Joel Brobecker
2010-11-08 16:38 ` Mark Kettenis
2010-11-08 16:43 ` Joel Brobecker
2010-11-08 16:54 ` Pedro Alves
2010-11-08 18:36 ` Joel Brobecker
2010-11-02 18:01 ` Joel Brobecker
2010-11-02 18:10 ` [doc RFA] Switch to GCC coding style Jan Kratochvil
2010-11-02 18:20 ` Doug Evans
2010-11-02 18:58 ` Joel Brobecker
2010-11-02 19:19 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103152723.GA2445@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ken@linux.vnet.ibm.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).