From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27567 invoked by alias); 3 Nov 2010 15:27:38 -0000 Received: (qmail 27557 invoked by uid 22791); 3 Nov 2010 15:27:36 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Nov 2010 15:27:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D06142BAC6F; Wed, 3 Nov 2010 11:27:26 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id W3raXJ6lo8rN; Wed, 3 Nov 2010 11:27:26 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7EDF62BAC6D; Wed, 3 Nov 2010 11:27:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3E292F588F; Wed, 3 Nov 2010 08:27:23 -0700 (PDT) Date: Wed, 03 Nov 2010 15:27:00 -0000 From: Joel Brobecker To: Ken Werner Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [patch] initial OpenCL C language support Message-ID: <20101103152723.GA2445@adacore.com> References: <201010221920.30046.ken@linux.vnet.ibm.com> <201010271535.05100.ken@linux.vnet.ibm.com> <20101102192311.GI2492@adacore.com> <201011031402.40132.ken@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201011031402.40132.ken@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00068.txt.bz2 > In case of C (and probably Ada as well) the lengths of the builtin > types depend on the architecuter/implementation but for OpenCL C it's > kind of the other way round. I hard coded the lengths because OpenCL > specifies fixed sizes of the builtin types: > http://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/scalarDataTypes.html > http://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/vectorDataTypes.html > Does this sound reasonable? It took me a while to understand the distinction in the GDB code between builtin types and primitive types, but I get it, now, and I understand the reason for the changes - thank you! Patch looks good to me, at this point. It needs documentation (doc/gdb.texinfo) and a NEWS entry. Can you send a separate patch for this portion. Once the documentation is approved, you may commit this patch as well. Thank you, -- Joel